From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: richard.leitner@linux.dev, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Ladislav Michl <ladis@linux-mips.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Benjamin Bara <benjamin.bara@skidata.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml
Date: Thu, 2 Mar 2023 14:31:14 +0100 [thread overview]
Message-ID: <27aa0b4a-14fc-5fce-ab49-a8744b131882@linaro.org> (raw)
In-Reply-To: <20230302-max9867-v1-1-aa9f7f25db5e@skidata.com>
On 02/03/2023 12:55, richard.leitner@linux.dev wrote:
> From: Richard Leitner <richard.leitner@skidata.com>
>
> Convert from max9867.txt to maxim,max9867.yaml and add missing
> '#sound-dai-cells' property.
Thank you for your patch. There is something to discuss/improve.
Except wrong ID (and missing test):
> +
> +examples:
> + - |
> + &i2c {
> + max9867: max9867@18 {
Generic node names, so "codec" and drop the unused label.
Use 4 spaces for example indentation.
> + compatible = "maxim,max9867";
> + #sound-dai-cells = <0>;
> + reg = <0x18>;
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-02 13:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 11:55 [PATCH 0/3] Add "mclk" support for maxim,max9867 richard.leitner
2023-03-02 11:55 ` [PATCH 1/3] ASoC: dt-bindings: maxim,max9867: convert txt bindings to yaml richard.leitner
2023-03-02 13:05 ` Rob Herring
2023-03-02 14:34 ` Richard Leitner
2023-03-02 13:31 ` Krzysztof Kozlowski [this message]
2023-03-02 13:48 ` Richard Leitner
2023-03-02 11:55 ` [PATCH 2/3] ASoC: dt-bindings: maxim,max9867: add "mclk" property richard.leitner
2023-03-02 13:31 ` Krzysztof Kozlowski
2023-03-02 14:56 ` Richard Leitner
2023-03-02 11:55 ` [PATCH 3/3] ASoC: maxim,max9867: add "mclk" support richard.leitner
2023-03-02 12:20 ` Mark Brown
2023-03-02 12:45 ` Richard Leitner
2023-03-02 12:45 ` Claudiu.Beznea
2023-03-02 14:46 ` Richard Leitner
2023-03-03 10:00 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27aa0b4a-14fc-5fce-ab49-a8744b131882@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=benjamin.bara@skidata.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=ladis@linux-mips.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=richard.leitner@linux.dev \
--cc=richard.leitner@skidata.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).