From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8168AC43334 for ; Wed, 6 Jul 2022 14:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231875AbiGFOfW (ORCPT ); Wed, 6 Jul 2022 10:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229767AbiGFOfW (ORCPT ); Wed, 6 Jul 2022 10:35:22 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07DBC17E1E for ; Wed, 6 Jul 2022 07:35:21 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id t24so26291352lfr.4 for ; Wed, 06 Jul 2022 07:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=vHzDk8iDFWu26W/brex+TMJ8rS3+AlVCn+1TtO/d/+w=; b=J6aEaA93f6HARN0t/xaA82XJaM88rLxgWepc8chGBv0nECRXeki8VoeFiLxbk0bD0W NECJ1vNaouHr3IyfPJEcxgkOj5p/xbvUvyLBpytO37yN5u2UmbJsFcNzJcn8NDBHt48k JOlyQBmcRJvvQf8MhHEF3PAlZN4cTRpAnGlU0PTzFmYT9irpHiG9yN6guR4setcg9okh dl+iEju53llS49uZgo+DBoF4kdjp+Zf0F1AVuNlEU+e+xQx0H65pxWjQK3ephirk+aB7 y80eFot9nKxq9aXCX7zRAlAlSMsOjjstIDgHEv/NqvjjABvIw66RIQ3wHPtNeQ4dNH2w yu+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vHzDk8iDFWu26W/brex+TMJ8rS3+AlVCn+1TtO/d/+w=; b=KoPX85DNRpQ7XjNr/ELwD9h6w7PdQ+ZPMZxVgcWL8fw5gvKSd7QvW9WO+sXkG2Ic28 diVoXewj3U085HB3qPGY++YWhnYw3epzjfh8WcHzFnqUBLxYkG7RGK//9HsCk9FkpKk9 JtmyqbMGgr4Eqe64gHGUwq/tj4QcXbvHf6PAhfM3o276t7lqCOkOYrAQDeK+jEG89dPl /hcgzV5BqLn+JSv/IfRNNKgz3LU1+Otw2Z3zwDxanGrkSSfcmfD+eJ9H+TnRkNq7PSMX VvMVlt3bBW4MH3ckuN5fZyiqWoxRjpJQkWXIRyGLFpqD+K5N2RX6gB74ewsezaLiTJTu iDwQ== X-Gm-Message-State: AJIora/Dkhqq0A9krJOhIyaUJ62fE+Ok7BLuzQIJ1jWfmpu3M3NVkXYs 9peZL4MtQWjtVvAJdi2AGJHgdw== X-Google-Smtp-Source: AGRyM1vZt21fHb4CPWwcERIsmHIfne9uEYyXkXvwQU6KzIQn9abhEBmceqxhXa74eYVxw2w3BF7y/Q== X-Received: by 2002:a05:6512:32c1:b0:47f:9d5b:d558 with SMTP id f1-20020a05651232c100b0047f9d5bd558mr27803365lfg.488.1657118119332; Wed, 06 Jul 2022 07:35:19 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id v23-20020a056512349700b0048600adb5d9sm425876lfr.10.2022.07.06.07.35.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 07:35:18 -0700 (PDT) Message-ID: <27c99ecf-75ab-1798-2b59-3be397d153d0@linaro.org> Date: Wed, 6 Jul 2022 16:35:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 08/16] arm64: dts: mt8195: Add power domains controller Content-Language: en-US To: Matthias Brugger , Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , AngeloGioacchino Del Regno , Enric Balletbo i Serra , Weiyi Lu Cc: iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220704100028.19932-1-tinghan.shen@mediatek.com> <20220704100028.19932-9-tinghan.shen@mediatek.com> <3b65405d-167f-a0c7-d15e-5da6f08d99b3@linaro.org> <17203a8a-407e-30cf-79de-352716c3ebce@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <17203a8a-407e-30cf-79de-352716c3ebce@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/07/2022 15:41, Matthias Brugger wrote: > > > On 04/07/2022 14:38, Krzysztof Kozlowski wrote: >> On 04/07/2022 12:00, Tinghan Shen wrote: >>> Add power domains controller node for mt8195. >>> >>> Signed-off-by: Weiyi Lu >>> Signed-off-by: Tinghan Shen >>> --- >>> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 327 +++++++++++++++++++++++ >>> 1 file changed, 327 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> index 8d59a7da3271..d52e140d9271 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi >>> @@ -10,6 +10,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> / { >>> compatible = "mediatek,mt8195"; >>> @@ -338,6 +339,332 @@ >>> #interrupt-cells = <2>; >>> }; >>> >>> + scpsys: syscon@10006000 { >>> + compatible = "syscon", "simple-mfd"; >> >> These compatibles cannot be alone. >> > > You mean we would need something like "mediatek,scpsys" as dummy compatible > that's not bound to any driver? Yes. syscon (and simple-mfd) must always come with a specific compatible. > >>> + reg = <0 0x10006000 0 0x1000>; >>> + #power-domain-cells = <1>; >> >> If it is simple MFD, then probably it is not a power domain provider. >> Decide. > > The SCPSYS IP block of MediaTek SoCs group several functionality, one is the > power domain controller. Others are not yet implemented, but defining the scpsys > as a MFD will give us the possibility to do so in the future. No, quite the opposite. Having simple-mfd prevents you from implementing it correctly later as a driver, because you cannot remove it. It would be ABI break. It's fine to have one block being a simple MFD having several children, but then it's not a power controller. Children could be such power controller, but not simple-mfd. Rob explained this several times: https://lore.kernel.org/all/YXhINE00HG6hbQI4@robh.at.kernel.org/ https://lore.kernel.org/all/20220701000959.GA3588170-robh@kernel.org/ Best regards, Krzysztof