From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
vincent.knecht@mailoo.org, matti.lehtimaki@gmail.com,
quic_grosikop@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init
Date: Wed, 8 Nov 2023 00:36:01 +0000 [thread overview]
Message-ID: <27cb79f8-2c44-48db-8f6d-c2ec861dc249@linaro.org> (raw)
In-Reply-To: <ff8532ca-fe74-4f52-bab9-b14f6a4599b1@linaro.org>
On 07/11/2023 21:43, Konrad Dybcio wrote:
>
>
> On 11/5/23 18:45, Bryan O'Donoghue wrote:
>> Add a PHY configuration sequence for the sc8280xp which uses a Qualcomm
>> Gen 2 version 1.1 CSI-2 PHY.
>>
>> The PHY can be configured as two phase or three phase in C-PHY or D-PHY
>> mode. This configuration supports two-phase D-PHY mode.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> Makes it sound like the current 2ph/3ph split is rather nonsensical?
>
> Perhaps we should restructure it to match hw revision? Especially since
> one can get it from the hardware itself..
>
> Konrad
For the C-PHY though we have to either add or remove caps - I forget
which on ~ all of our reference platforms.
"The PHY can do it" but I'd be surprised to find there's a single real
implementation of it outside of a silicon test bench.
---
bod
next prev parent reply other threads:[~2023-11-08 0:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-05 17:44 [PATCH v3 0/6] media: qcom: camss: Add sc8280xp support Bryan O'Donoghue
2023-11-05 17:45 ` [PATCH v3 1/6] media: dt-bindings: media: camss: Add qcom,sc8280xp-camss binding Bryan O'Donoghue
2023-11-05 18:25 ` Rob Herring
2023-11-05 18:27 ` Krzysztof Kozlowski
2023-11-05 17:45 ` [PATCH v3 2/6] media: qcom: camss: Add CAMSS_SC8280XP enum Bryan O'Donoghue
2023-11-05 17:45 ` [PATCH v3 3/6] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 two-phase MIPI CSI-2 DPHY init Bryan O'Donoghue
2023-11-07 21:43 ` Konrad Dybcio
2023-11-08 0:36 ` Bryan O'Donoghue [this message]
2023-11-05 17:45 ` [PATCH v3 4/6] media: qcom: camss: Add sc8280xp resource details Bryan O'Donoghue
2023-11-07 21:48 ` Konrad Dybcio
2023-11-08 0:47 ` Bryan O'Donoghue
2023-11-05 17:45 ` [PATCH v3 5/6] media: qcom: camss: Add sc8280xp support Bryan O'Donoghue
2023-11-07 21:37 ` Konrad Dybcio
2023-11-05 17:45 ` [PATCH v3 6/6] media: qcom: camss: vfe-17x: Rename camss-vfe-170 to camss-vfe-17x Bryan O'Donoghue
2023-11-07 21:41 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27cb79f8-2c44-48db-8f6d-c2ec861dc249@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matti.lehtimaki@gmail.com \
--cc=mchehab@kernel.org \
--cc=quic_grosikop@quicinc.com \
--cc=rfoss@kernel.org \
--cc=robh+dt@kernel.org \
--cc=todor.too@gmail.com \
--cc=vincent.knecht@mailoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).