From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4BAC43334 for ; Wed, 13 Jul 2022 07:50:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234795AbiGMHu5 (ORCPT ); Wed, 13 Jul 2022 03:50:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234690AbiGMHux (ORCPT ); Wed, 13 Jul 2022 03:50:53 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 204C9C84C5 for ; Wed, 13 Jul 2022 00:50:52 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id n18so16047958lfq.1 for ; Wed, 13 Jul 2022 00:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=NYflSyzJGWVmdo/FfUNnh/uWyzXsbzDiU5Kfi3yNT/s=; b=T8PSBsSZ/kqgVoJWl1fOj4dHcsCxbJGi1zOLnZJzpdNI3O5NOJwql6sobP0r3Z1OQd oFnUu6Vr5VpQoaF5ZA2ltfQIhfhw0KOj0IC7ZY6BXomA+yv50aY2SHmUkNJi1T7t1iuK clsGR5WG4tBsWwsBQDdKv9WX3smAnXnZ1/NdCLShi1x1Aztc3iwzPdK2r7QbfLOgJ8SY Bsctvhnv3CXHSZT1zMF9vzwZ8fBXuRXU0B0dcBY8wsCLgCTsR3y5JEc9lYDqF74bBdJU ErJWwbjZs6rYngrmSRBQggbaEzWhRoPB6mj3QhoDpZVLZfjP5SK3mLs9nwpO/54HNeDt rd2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=NYflSyzJGWVmdo/FfUNnh/uWyzXsbzDiU5Kfi3yNT/s=; b=dhDAcSkmxEBTToquzWMywTK1OgC0P092pkMAXQ3klLEKMNH8YDxL5fouZjgzgjD1Dr S8wNmyBxRFNqKnuv+wWIMRj1BEsmPnikfeOF79294Tx39iYPsqaKhPjdDohGKoLWKo4F W4ORk+8Jy9mkLMZK69Fsii5n46EPsWWboCJ1hQTN5SB+yfll6ZtfgpYfWwrpqJ22l89d y45MoPTMi2WkmExWVnuS+Lmxy3/jA8QZW2px1ckAYWVa4D2IihC00e4Q8MY0NnoUKmkp ClE/mdLUHzfk4gvHltdEV0/36RFQuaAV5+wxIcHPBrUPjVEksEqXSgARlrl/lMxlm5wA JUVA== X-Gm-Message-State: AJIora/6CQLybtW9lxw5P+9tjVT6nsBznCj+uVqkwYpZKSJhu0JND9sE mwdLkJFJx82lEvLIjjWE99K+yg== X-Google-Smtp-Source: AGRyM1uhLHRvLlcQa7QUDMxWa/Z5td7UZ9SmBf3XHNCP14Y3Qepv291ZjDvXremjm/dWmogsSMB6og== X-Received: by 2002:a05:6512:150e:b0:481:60af:a5a5 with SMTP id bq14-20020a056512150e00b0048160afa5a5mr1161136lfb.524.1657698650422; Wed, 13 Jul 2022 00:50:50 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id 3-20020a2e0503000000b0025d39993856sm2955769ljf.127.2022.07.13.00.50.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 00:50:50 -0700 (PDT) Message-ID: <27cd6e98-50c6-14b2-aec0-b4bbd49a9da8@linaro.org> Date: Wed, 13 Jul 2022 09:50:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v10 2/2] dt-bindings: thermal: Add Sunplus schema Content-Language: en-US To: Li-hao Kuo , rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lh.kuo@sunplus.com References: <5d2c95959dd6efaa204bc80ca9b24a8be9293d2f.1654660009.git.lhjeff911@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <5d2c95959dd6efaa204bc80ca9b24a8be9293d2f.1654660009.git.lhjeff911@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2022 09:30, Li-hao Kuo wrote: > Add bindings for Sunplus thermal driver > > Signed-off-by: Li-hao Kuo > --- > Changes in v10: > - Fix wrong indentation. > - Change the setting of compatible. > - Mosdify the setting of remove funciton. > > .../bindings/thermal/sunplus,thermal.yaml | 43 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml > new file mode 100644 > index 0000000..52094da > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sunplus,thermal.yaml > @@ -0,0 +1,43 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright (C) Sunplus Co., Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sunplus,thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sunplus Thermal controller > + > +maintainers: > + - Li-hao Kuo > + > +properties: > + compatible: > + enum: > + - sunplus,sp7021-thermal > + > + reg: > + maxItems: 1 > + > + nvmem-cells: > + maxItems: 1 > + > + nvmem-cell-names: > + const: calib > + > +required: > + - compatible > + - reg > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + thermal@9c000280 { > + compatible = "sunplus,sp7021-thermal"; > + reg = <0x9c000280 0xc>; > + nvmem-cells = <&calib>; > + nvmem-cell-names = "calib"; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 23bde07..a8c44eb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19107,6 +19107,7 @@ SUNPLUS THERMAL DRIVER > M: Li-hao Kuo > L: linux-pm@vger.kernel.org > S: Maintained > +F: Documentation/devicetree/bindings/thermal/sunplus_thermal.yaml Not a correct path anymore. Around v7 I asked to name the file either sunplus,thermal.yaml or sunplus,sp7021-thermal.yaml, but actually that was my mistake a bit which I learnt later. The only recommended name is the latter, based on compatible, so: sunplus,sp7021-thermal.yaml Please name the bindings "sunplus,sp7021-thermal.yaml", change the $id and maintainers entry to new filename. Best regards, Krzysztof