From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH v3 0/7] ASoC: codecs: add wcd938x support
Date: Fri, 19 Mar 2021 11:09:06 -0500 [thread overview]
Message-ID: <27e19637-b9ea-1adb-46e5-252480a9a353@linux.intel.com> (raw)
In-Reply-To: <20210319092919.21218-1-srinivas.kandagatla@linaro.org>
On 3/19/21 4:29 AM, Srinivas Kandagatla wrote:
> This patchset adds support for Qualcomm WCD938X codec.
>
> Qualcomm WCD9380/WCD9385 Codec is a standalone Hi-Fi audio codec IC
> connected over SoundWire. This device has two SoundWire devices, RX and
> TX respectively supporting 4 x ADCs, ClassH, Ear, Aux PA, 2xHPH,
> 7 x TX diff inputs, 8 DMICs and MBHC.
>
> Even though this device has two SoundWire devices, only tx device has
> access to main codec Control/Status Registers!
That part is a new concept we haven't seen so far with SoundWire
support, and I added a number of comments in the patches.
It would really help if you could add more explanations on how
regmap/pm_runtime/gpios/regulators/interrupts are supposed to work with
such a functional split. Thanks!
> This patchset along with other SoundWire patches on the list
> have been tested on SM8250 MTP device.
>
> Am planning to send support for MBHC once this driver gets accepted!
>
> Thanks,
> srini
>
> Many thanks for reviewing v2.
>
>
> Changes since v2:
> - fixed dt_binding_check error
>
>
> Srinivas Kandagatla (7):
> ASoC: dt-bindings: wcd938x: add bindings for wcd938x
> ASoC: codecs: wcd-clsh: add new version support
> ASoC: codecs: wcd938x: add basic driver
> ASoC: codecs: wcd938x: add basic controls
> ASoC: codecs: wcd938x: add playback dapm widgets
> ASoC: codecs: wcd938x: add capture dapm widgets
> ASoC: codecs: wcd938x: add audio routing
>
> .../bindings/sound/qcom,wcd938x.yaml | 165 +
> sound/soc/codecs/Kconfig | 9 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/wcd-clsh-v2.c | 350 +-
> sound/soc/codecs/wcd-clsh-v2.h | 16 +
> sound/soc/codecs/wcd938x-sdw.c | 291 ++
> sound/soc/codecs/wcd938x.c | 3623 +++++++++++++++++
> sound/soc/codecs/wcd938x.h | 676 +++
> 8 files changed, 5122 insertions(+), 10 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd938x.yaml
> create mode 100644 sound/soc/codecs/wcd938x-sdw.c
> create mode 100644 sound/soc/codecs/wcd938x.c
> create mode 100644 sound/soc/codecs/wcd938x.h
>
next prev parent reply other threads:[~2021-03-19 16:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 9:29 [PATCH v3 0/7] ASoC: codecs: add wcd938x support Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 1/7] ASoC: dt-bindings: wcd938x: add bindings for wcd938x Srinivas Kandagatla
2021-03-26 1:52 ` Rob Herring
2021-03-19 9:29 ` [PATCH v3 2/7] ASoC: codecs: wcd-clsh: add new version support Srinivas Kandagatla
2021-03-19 15:23 ` Pierre-Louis Bossart
2021-03-22 10:26 ` Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 3/7] ASoC: codecs: wcd938x: add basic driver Srinivas Kandagatla
2021-03-19 15:59 ` Pierre-Louis Bossart
2021-03-22 10:27 ` Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 4/7] ASoC: codecs: wcd938x: add basic controls Srinivas Kandagatla
2021-03-19 16:03 ` Pierre-Louis Bossart
2021-03-19 9:29 ` [PATCH v3 5/7] ASoC: codecs: wcd938x: add playback dapm widgets Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 6/7] ASoC: codecs: wcd938x: add capture " Srinivas Kandagatla
2021-03-19 9:29 ` [PATCH v3 7/7] ASoC: codecs: wcd938x: add audio routing Srinivas Kandagatla
2021-03-19 16:06 ` Pierre-Louis Bossart
2021-03-19 16:09 ` Pierre-Louis Bossart [this message]
2021-03-22 10:27 ` [PATCH v3 0/7] ASoC: codecs: add wcd938x support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27e19637-b9ea-1adb-46e5-252480a9a353@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).