Re: [PATCH v3 18/20] arm64: dts: google: Add initial Oriole/pixel 6 board support

[Stephen Boyd <sboyd@kernel.org>]

Quoting Peter Griffin (2023-10-11 11:48:21)
> diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dts b/arch/arm64/boot/dts/google/gs101-oriole.dts
> new file mode 100644
> index 000000000000..3bebca989d34
> --- /dev/null
> +++ b/arch/arm64/boot/dts/google/gs101-oriole.dts
> @@ -0,0 +1,79 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Oriole Device Tree
> + *
> + * Copyright 2021-2023 Google,LLC
> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include "gs101-pinctrl.h"
> +#include "gs101.dtsi"
> +
> +/ {
> +       model = "Oriole";
> +       compatible = "google,gs101-oriole", "google,gs101";
> +
> +       chosen {
> +               bootargs = "earlycon=exynos4210,mmio32,0x10A00000 console=ttySAC0";
> +       };
> +
> +       gpio-keys {
> +               compatible = "gpio-keys";
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&key_voldown &key_volup &key_power>;

When a phandle starts an array presumably the next element after it is
some cell or "argument" for that phandle. In this case, &key_voldown
doesn't have any cells (there isn't a #pinctrl-cells property) so we
typically write it like this

		pinctrl-0 = <&key_voldown>, <&key_volup>, <&key_power>;

so that the reader doesn't think the phandles are related. In the DTB
nothing is different from how you have it in this patch. This is a super
nitpick!