From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: media: qcom,sc8280xp-camss: Fix interrupt types
Date: Tue, 8 Oct 2024 12:50:27 +0100 [thread overview]
Message-ID: <27f39cda-932c-4b79-84d4-be78d266ebdf@linaro.org> (raw)
In-Reply-To: <4bf490cb-228d-4f01-a956-cacbafa94e2a@linaro.org>
On 08/10/2024 12:37, Vladimir Zapolskiy wrote:
>
> I don't have access to datasheets or hardware of sc8280xp powered board,
> someone may either verify, if CAMSS level high type interrupts are
> supported/working at all or not (obviously its current presence in dts is
> insufficient), or check the SoC datasheet.
I've tested both as was submitted and your change.
I _always_ test my patches. I'm not sure there's a datasheet which
spells this out to be honest.
Rising or High can both be justified, its really down to how your
interrupt controller latches the state change. However I personally am
fine with the change you've provided because I trust it fixes an error
for you.
I didn't try loading and unloading that module but, since you did I'm
happy to Ack the change and trust your work.
---
bod
next prev parent reply other threads:[~2024-10-08 11:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 7:28 [PATCH v2 0/6] media: dt-bindings: media: camss: Fix interrupt types Vladimir Zapolskiy
2024-09-23 7:28 ` [PATCH v2 1/6] dt-bindings: media: qcom,sc8280xp-camss: " Vladimir Zapolskiy
2024-10-06 2:36 ` Bjorn Andersson
2024-10-08 10:02 ` Vladimir Zapolskiy
2024-10-08 11:15 ` Krzysztof Kozlowski
2024-10-08 11:37 ` Vladimir Zapolskiy
2024-10-08 11:45 ` Krzysztof Kozlowski
2024-10-08 12:03 ` Vladimir Zapolskiy
2024-10-08 12:06 ` Krzysztof Kozlowski
2024-10-08 12:20 ` Vladimir Zapolskiy
2024-10-08 11:50 ` Bryan O'Donoghue [this message]
2024-10-08 12:00 ` Vladimir Zapolskiy
2024-10-08 13:24 ` Bryan O'Donoghue
2024-10-08 15:38 ` Vladimir Zapolskiy
2024-10-08 15:51 ` Bryan O'Donoghue
2024-10-08 16:24 ` Depeng Shao
2024-10-09 12:56 ` Bryan O'Donoghue
2024-10-08 12:01 ` Krzysztof Kozlowski
2024-10-08 12:11 ` Vladimir Zapolskiy
2024-10-08 13:38 ` Bryan O'Donoghue
2024-10-08 11:17 ` Krzysztof Kozlowski
2024-09-23 7:28 ` [PATCH v2 2/6] dt-bindings: media: qcom,sdm845-camss: " Vladimir Zapolskiy
2024-09-23 7:28 ` [PATCH v2 3/6] dt-bindings: media: qcom,sm8250-camss: " Vladimir Zapolskiy
2024-09-23 7:28 ` [PATCH v2 4/6] arm64: dts: qcom: sc8280xp: Fix interrupt type of camss interrupts Vladimir Zapolskiy
2024-10-06 2:39 ` Bjorn Andersson
2024-09-23 7:28 ` [PATCH v2 5/6] arm64: dts: qcom: sdm845: Fix interrupt types " Vladimir Zapolskiy
2024-09-23 7:28 ` [PATCH v2 6/6] arm64: dts: qcom: sm8250: " Vladimir Zapolskiy
2024-09-23 12:43 ` [PATCH v2 0/6] media: dt-bindings: media: camss: Fix interrupt types Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f39cda-932c-4b79-84d4-be78d266ebdf@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).