From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rudraksha Gupta <guptarud@gmail.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, david@ixit.cz,
devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v2 2/2] ARM: msm8960: Add Samsung Galaxy Express support
Date: Tue, 9 Aug 2022 08:35:18 +0300 [thread overview]
Message-ID: <27f83048-ac75-97eb-c9f0-0829de30e1ad@linaro.org> (raw)
In-Reply-To: <20220809000300.6384-2-guptarud@gmail.com>
On 09/08/2022 03:03, Rudraksha Gupta wrote:
> This adds a very basic device tree file for the Samsung Galaxy Express
> SGH-I437. Currently, the following things work: UART, eMMC, SD Card, and
> USB.
Use subject prefix matching the subsystem.
>
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> v2:
> - Group the correct changes together
>
> arch/arm/boot/dts/Makefile | 1 +
> .../dts/qcom-msm8960-samsung-expressatt.dts | 337 ++++++++++++++++++
> 2 files changed, 338 insertions(+)
> create mode 100644 arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..d55f196ad733 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1049,6 +1049,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
> qcom-msm8660-surf.dtb \
> qcom-msm8916-samsung-serranove.dtb \
> qcom-msm8960-cdp.dtb \
> + qcom-msm8960-samsung-expressatt.dtb \
> qcom-msm8974-lge-nexus5-hammerhead.dtb \
> qcom-msm8974-sony-xperia-rhine-amami.dtb \
> qcom-msm8974-sony-xperia-rhine-honami.dtb \
> diff --git a/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> new file mode 100644
> index 000000000000..cf557f0c9a59
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom-msm8960-samsung-expressatt.dts
> @@ -0,0 +1,337 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +#include <dt-bindings/input/input.h>
> +#include "qcom-msm8960.dtsi"
> +
> +/ {
> + model = "Samsung Galaxy S3 SGH-I437";
> + compatible = "samsung,expressatt", "qcom,msm8960";
Undocumented compatible. Run checkpatch.
> +
> + aliases {
> + serial0 = &gsbi5_serial;
> + };
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> +
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
These three properties are confusing. Why adding them?
> + };
> +
> + soc {
> + gsbi@16400000 {
Override by alias.
> + status = "ok";
okay, not ok. Status goes at the end of properties.
> + qcom,mode = <GSBI_PROT_I2C_UART>;
> + serial@16440000 {
> + status = "ok";
Same comments.
> + };
> + };
> +
> + amba {
> + /* eMMC */
> + sdcc1: mmc@12400000 {
OK, I'll abandon the review. This file is really not matching anything
in the upstream. Please start your work from a proper upstreamed, recent
board.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-09 5:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-08 23:47 [PATCH 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Rudraksha Gupta
2022-08-08 23:47 ` [PATCH 2/2] ARM: msm8960: Add Samsung Galaxy Express support Rudraksha Gupta
2022-08-09 0:02 ` [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Rudraksha Gupta
2022-08-09 0:03 ` [PATCH v2 2/2] ARM: msm8960: Add Samsung Galaxy Express support Rudraksha Gupta
2022-08-09 5:35 ` Krzysztof Kozlowski [this message]
2022-08-09 23:57 ` Rudraksha Gupta
2022-08-10 7:47 ` Krzysztof Kozlowski
2022-08-09 5:32 ` [PATCH v2 1/2] ARM: msm8960: Rename cxo_board to cxo-board and add alias Krzysztof Kozlowski
2022-08-10 19:53 ` Bjorn Andersson
2022-08-11 2:51 ` Rudraksha Gupta
2022-08-29 21:54 ` Bjorn Andersson
2023-02-21 6:40 ` Rudraksha Gupta
2022-08-09 5:30 ` [PATCH " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27f83048-ac75-97eb-c9f0-0829de30e1ad@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=guptarud@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).