From: Jon Hunter <jonathanh@nvidia.com>
To: Shubhi Garg <shgarg@nvidia.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
thierry.reding@gmail.com, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies
Date: Fri, 21 Jul 2023 14:26:23 +0100 [thread overview]
Message-ID: <28041fb7-c49c-dab6-b62d-83778f7b7f5f@nvidia.com> (raw)
In-Reply-To: <20230531085052.3082394-1-shgarg@nvidia.com>
On 31/05/2023 09:50, Shubhi Garg wrote:
> Add the 3.3V supplies for PCIe C1 controller and Display Port controller
> for the NVIDIA IGX Orin platform.
>
> Signed-off-by: Shubhi Garg <shgarg@nvidia.com>
> ---
> .../nvidia/tegra234-p3740-0002+p3701-0008.dts | 1 +
> .../boot/dts/nvidia/tegra234-p3740-0002.dtsi | 28 +++++++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> index 43d797e5544f..c0ba69c16382 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> @@ -35,6 +35,7 @@
> pcie@14100000 {
> status = "okay";
> vddio-pex-ctl-supply = <&vdd_1v8_ao>;
> + vpcie3v3-supply = <&vdd_3v3_wifi>;
> phys = <&p2u_hsio_3>;
> phy-names = "p2u-0";
> };
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> index c95063b19321..7f6c34b79491 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002.dtsi
> @@ -134,4 +134,32 @@
> "usb3-0", "usb3-1", "usb3-2";
> };
> };
> +
> + vdd_3v3_dp: regulator-vdd-3v3-dp {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-3v3-dp";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vdd_3v3_sys>;
> + gpio = <&gpio TEGRA234_MAIN_GPIO(H, 6) 0>;
> + enable-active-high;
> + regulator-always-on;
> + };
> +
> + vdd_3v3_sys: regulator-vdd-3v3-sys {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-3v3-sys";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + vdd_3v3_wifi: regulator-vdd-3v3-wifi {
> + compatible = "regulator-fixed";
> + regulator-name = "vdd-3v3-wifi";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&gpio TEGRA234_MAIN_GPIO(G, 3) GPIO_ACTIVE_HIGH>;
> + regulator-boot-on;
> + enable-active-high;
> + };
> };
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Thierry, OK to pick this up?
Jon
--
nvpublic
next prev parent reply other threads:[~2023-07-21 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:50 [PATCH] arm64: tegra: Add PCIe and DP 3.3V supplies Shubhi Garg
2023-07-21 13:26 ` Jon Hunter [this message]
2023-07-21 15:19 ` Thierry Reding
2023-07-21 15:21 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28041fb7-c49c-dab6-b62d-83778f7b7f5f@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shgarg@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).