From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 0/3] Rockchip IOMMU driver and devicetree bindings Date: Thu, 23 Oct 2014 18:23 +0200 Message-ID: <2804227.ziAnEUAn0E@diego> References: <1412158843-8115-1-git-send-email-djkurtz@chromium.org> <20141022152019.GK10074@8bytes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Daniel Kurtz Cc: Joerg Roedel , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Grant Likely , Simon Xue , Grant Grundler , =?ISO-8859-1?Q?St=E9phane?= Marchesin , "open list:OPEN FIRMWARE AND..." , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:IOMMU DRIVERS" , "open list:ARM/Rockchip SoC..." List-Id: devicetree@vger.kernel.org Am Freitag, 24. Oktober 2014, 00:11:06 schrieb Daniel Kurtz: > On Wed, Oct 22, 2014 at 11:20 PM, Joerg Roedel wrote: > > On Wed, Oct 01, 2014 at 06:20:40PM +0800, Daniel Kurtz wrote: > > > Add a driver and devicetree bindings for the IOMMU found in Rockchip > > > > RK3288 > > > > > SoCs. > > > > > > Daniel Kurtz (3): > > > iommu/rockchip: rk3288 iommu driver > > > dt-bindings: iommu: Add documentation for rockchip iommu > > > ARM: dts: rk3288: add VOP iommu nodes > > > > > > .../devicetree/bindings/iommu/rockchip,iommu.txt | 26 + > > > arch/arm/boot/dts/rk3288.dtsi | 18 + > > > drivers/iommu/Kconfig | 11 + > > > drivers/iommu/Makefile | 1 + > > > drivers/iommu/rockchip-iommu.c | 924 > > > > +++++++++++++++++++++ > > > > > 5 files changed, 980 insertions(+) > > > create mode 100644 > > > > Documentation/devicetree/bindings/iommu/rockchip,iommu.txt > > > > > create mode 100644 drivers/iommu/rockchip-iommu.c > > > > Please make sure you also get Acks for the DT bindings. With that and > > the issue I mentioned in the other email fixed, I will apply these > > patches? > > Hi Joerg, > > Thanks for your reviews. > Can you help me get these DT bindings Acked? > AFAICT, the DT maintainers are CC'ed on this patch, I'm not sure what else > to do. I think the generally accepted way is, to give the dt maintainers an appropriate amount of time [0] to complain and assume an implicit ack if no complaint arrives. This is especially true, as the dt-binding for the iommu itself does not even introduce any new properties and simply uses widely established ones. As a sidenote ... I'd like to take the dts changes in patch 3, once Joerg takes patches 1 and 2. Heiko [0] 3 weeks seems to be the most widely used timespan