* [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 @ 2024-11-04 8:56 Alexander Stein 2024-11-04 16:26 ` Rob Herring (Arm) 2025-04-09 10:59 ` Alexander Stein 0 siblings, 2 replies; 8+ messages in thread From: Alexander Stein @ 2024-11-04 8:56 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan Cc: Alexander Stein, devicetree, imx, linux-arm-kernel, linux-kernel BBM protocol supports a single power button, supported by driver imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten using linux,code. Add a reference to this schema and add linux,code as a supported property. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- Changes in v2: * Added default value .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml index 1a95010a546b1..c1b7140ee0098 100644 --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml @@ -12,13 +12,19 @@ maintainers: properties: protocol@81: - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' - unevaluatedProperties: false + type: object + allOf: + - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' + - $ref: /schemas/input/input.yaml# + additionalProperties: false properties: reg: const: 0x81 + linux,code: + default: 116 # KEY_POWER + protocol@84: $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' unevaluatedProperties: false -- 2.34.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 2024-11-04 8:56 [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 Alexander Stein @ 2024-11-04 16:26 ` Rob Herring (Arm) 2025-04-09 10:59 ` Alexander Stein 1 sibling, 0 replies; 8+ messages in thread From: Rob Herring (Arm) @ 2024-11-04 16:26 UTC (permalink / raw) To: Alexander Stein Cc: Pengutronix Kernel Team, Krzysztof Kozlowski, devicetree, Conor Dooley, Sascha Hauer, imx, Peng Fan, linux-arm-kernel, linux-kernel, Fabio Estevam, Shawn Guo On Mon, 04 Nov 2024 09:56:21 +0100, Alexander Stein wrote: > BBM protocol supports a single power button, supported by driver > imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten > using linux,code. Add a reference to this schema and add linux,code as a > supported property. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > Changes in v2: > * Added default value > > .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 2024-11-04 8:56 [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 Alexander Stein 2024-11-04 16:26 ` Rob Herring (Arm) @ 2025-04-09 10:59 ` Alexander Stein 2025-04-09 12:18 ` Peng Fan 1 sibling, 1 reply; 8+ messages in thread From: Alexander Stein @ 2025-04-09 10:59 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan Cc: devicetree, imx, linux-arm-kernel, linux-kernel Hi, Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: > BBM protocol supports a single power button, supported by driver > imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten > using linux,code. Add a reference to this schema and add linux,code as a > supported property. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Is there any other feedback or things to do here? Thanks Alexander > --- > Changes in v2: > * Added default value > > .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > index 1a95010a546b1..c1b7140ee0098 100644 > --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml > @@ -12,13 +12,19 @@ maintainers: > > properties: > protocol@81: > - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > - unevaluatedProperties: false > + type: object > + allOf: > + - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > + - $ref: /schemas/input/input.yaml# > + additionalProperties: false > > properties: > reg: > const: 0x81 > > + linux,code: > + default: 116 # KEY_POWER > + > protocol@84: > $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' > unevaluatedProperties: false > -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 2025-04-09 10:59 ` Alexander Stein @ 2025-04-09 12:18 ` Peng Fan 2025-04-09 12:31 ` Sudeep Holla 0 siblings, 1 reply; 8+ messages in thread From: Peng Fan @ 2025-04-09 12:18 UTC (permalink / raw) To: Alexander Stein, Sudeep Holla, Cristian Marussi Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx, linux-arm-kernel, linux-kernel + SCMI maintainer, Sudeep and Cristian On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote: >Hi, > >Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: >> BBM protocol supports a single power button, supported by driver >> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten >> using linux,code. Add a reference to this schema and add linux,code as a >> supported property. >> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > >Is there any other feedback or things to do here? I see Rob already gave R-b. Not sure this should go through Shawn's or Sudeep's tree. Regards, Peng > >Thanks >Alexander > >> --- >> Changes in v2: >> * Added default value >> >> .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml >> index 1a95010a546b1..c1b7140ee0098 100644 >> --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml >> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml >> @@ -12,13 +12,19 @@ maintainers: >> >> properties: >> protocol@81: >> - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' >> - unevaluatedProperties: false >> + type: object >> + allOf: >> + - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' >> + - $ref: /schemas/input/input.yaml# >> + additionalProperties: false >> >> properties: >> reg: >> const: 0x81 >> >> + linux,code: >> + default: 116 # KEY_POWER >> + >> protocol@84: >> $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node' >> unevaluatedProperties: false >> > > >-- >TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany >Amtsgericht München, HRB 105018 >Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider >http://www.tq-group.com/ > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 2025-04-09 12:18 ` Peng Fan @ 2025-04-09 12:31 ` Sudeep Holla 2025-04-09 16:00 ` Peng Fan 0 siblings, 1 reply; 8+ messages in thread From: Sudeep Holla @ 2025-04-09 12:31 UTC (permalink / raw) To: Peng Fan Cc: Alexander Stein, Cristian Marussi, Sudeep Holla, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx, linux-arm-kernel, linux-kernel On Wed, Apr 09, 2025 at 08:18:29PM +0800, Peng Fan wrote: > + SCMI maintainer, Sudeep and Cristian > > On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote: > >Hi, > > > >Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: > >> BBM protocol supports a single power button, supported by driver > >> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten > >> using linux,code. Add a reference to this schema and add linux,code as a > >> supported property. > >> > >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > >Is there any other feedback or things to do here? > > I see Rob already gave R-b. > > Not sure this should go through Shawn's or Sudeep's tree. > I am fine either way. Peng, just let me know if you want to pick this up. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 2025-04-09 12:31 ` Sudeep Holla @ 2025-04-09 16:00 ` Peng Fan 2025-05-13 15:37 ` [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux, code " Alexander Stein 0 siblings, 1 reply; 8+ messages in thread From: Peng Fan @ 2025-04-09 16:00 UTC (permalink / raw) To: Sudeep Holla Cc: Alexander Stein, Cristian Marussi, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx, linux-arm-kernel, linux-kernel Hi Sudeep, On Wed, Apr 09, 2025 at 01:31:58PM +0100, Sudeep Holla wrote: >On Wed, Apr 09, 2025 at 08:18:29PM +0800, Peng Fan wrote: >> + SCMI maintainer, Sudeep and Cristian >> >> On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote: >> >Hi, >> > >> >Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: >> >> BBM protocol supports a single power button, supported by driver >> >> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten >> >> using linux,code. Add a reference to this schema and add linux,code as a >> >> supported property. >> >> >> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> >> > >> >Is there any other feedback or things to do here? >> >> I see Rob already gave R-b. >> >> Not sure this should go through Shawn's or Sudeep's tree. >> > >I am fine either way. Peng, just let me know if you want to pick this up. Not my patch :) Since scmi driver changes go through your tree, the binding changes should follow same. It would be good that if you could pick it up. Thanks, Peng > >-- >Regards, >Sudeep > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux, code for protocol@81 2025-04-09 16:00 ` Peng Fan @ 2025-05-13 15:37 ` Alexander Stein 2025-05-13 17:25 ` Sudeep Holla 0 siblings, 1 reply; 8+ messages in thread From: Alexander Stein @ 2025-05-13 15:37 UTC (permalink / raw) To: Sudeep Holla Cc: Peng Fan, Cristian Marussi, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx, linux-arm-kernel, linux-kernel Hi Sudeep, Am Mittwoch, 9. April 2025, 18:00:29 CEST schrieb Peng Fan: > Hi Sudeep, > > On Wed, Apr 09, 2025 at 01:31:58PM +0100, Sudeep Holla wrote: > >On Wed, Apr 09, 2025 at 08:18:29PM +0800, Peng Fan wrote: > >> + SCMI maintainer, Sudeep and Cristian > >> > >> On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote: > >> >Hi, > >> > > >> >Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: > >> >> BBM protocol supports a single power button, supported by driver > >> >> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten > >> >> using linux,code. Add a reference to this schema and add linux,code as a > >> >> supported property. > >> >> > >> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > >> > > >> >Is there any other feedback or things to do here? > >> > >> I see Rob already gave R-b. > >> > >> Not sure this should go through Shawn's or Sudeep's tree. > >> > > > >I am fine either way. Peng, just let me know if you want to pick this up. > > Not my patch :) > > Since scmi driver changes go through your tree, the binding changes > should follow same. > > It would be good that if you could pick it up. A gentle ping. Best regards Alexander -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux, code for protocol@81 2025-05-13 15:37 ` [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux, code " Alexander Stein @ 2025-05-13 17:25 ` Sudeep Holla 0 siblings, 0 replies; 8+ messages in thread From: Sudeep Holla @ 2025-05-13 17:25 UTC (permalink / raw) To: Alexander Stein Cc: Peng Fan, Sudeep Holla, Cristian Marussi, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Peng Fan, devicetree, imx, linux-arm-kernel, linux-kernel On Tue, May 13, 2025 at 05:37:36PM +0200, Alexander Stein wrote: > Hi Sudeep, > > Am Mittwoch, 9. April 2025, 18:00:29 CEST schrieb Peng Fan: > > Hi Sudeep, > > > > On Wed, Apr 09, 2025 at 01:31:58PM +0100, Sudeep Holla wrote: > > >On Wed, Apr 09, 2025 at 08:18:29PM +0800, Peng Fan wrote: > > >> + SCMI maintainer, Sudeep and Cristian > > >> > > >> On Wed, Apr 09, 2025 at 12:59:50PM +0200, Alexander Stein wrote: > > >> >Hi, > > >> > > > >> >Am Montag, 4. November 2024, 09:56:21 CEST schrieb Alexander Stein: > > >> >> BBM protocol supports a single power button, supported by driver > > >> >> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten > > >> >> using linux,code. Add a reference to this schema and add linux,code as a > > >> >> supported property. > > >> >> > > >> >> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > >> > > > >> >Is there any other feedback or things to do here? > > >> > > >> I see Rob already gave R-b. > > >> > > >> Not sure this should go through Shawn's or Sudeep's tree. > > >> > > > > > >I am fine either way. Peng, just let me know if you want to pick this up. > > > > Not my patch :) > > > > Since scmi driver changes go through your tree, the binding changes > > should follow same. > > > > It would be good that if you could pick it up. > > A gentle ping. > Sorry I missed Peng's response. I have already sent my PR for v6.16 Since there is no driver changes, I thought it would be routed elsewhere. See if Rob or Shawn can pick it up for v6.16, else I can pick it up for v6.17, sorry for that. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-05-13 17:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-11-04 8:56 [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81 Alexander Stein 2024-11-04 16:26 ` Rob Herring (Arm) 2025-04-09 10:59 ` Alexander Stein 2025-04-09 12:18 ` Peng Fan 2025-04-09 12:31 ` Sudeep Holla 2025-04-09 16:00 ` Peng Fan 2025-05-13 15:37 ` [PATCH v2 1/1] dt-bindings: firmware: imx95-scmi: Allow linux, code " Alexander Stein 2025-05-13 17:25 ` Sudeep Holla
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).