From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98FFCC6FD18 for ; Wed, 19 Apr 2023 10:22:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232693AbjDSKWn (ORCPT ); Wed, 19 Apr 2023 06:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232327AbjDSKWm (ORCPT ); Wed, 19 Apr 2023 06:22:42 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D9C74EEC for ; Wed, 19 Apr 2023 03:22:38 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id iw7-20020a05600c54c700b003f16fce55b5so1193058wmb.0 for ; Wed, 19 Apr 2023 03:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681899756; x=1684491756; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=fU2wrMIC42PqEyjIjG+AcTqJMu7tdAgxZ3YGA63S+ss=; b=RweJHU7K9YVIDRY8mwPkF0JFg0GxNdl0lmXPL7bK3kiIdciBN9YA/Gh8LWECNT83yo RXe2GiJ3d//2Xa4JrXfrgPvdw+spLWr6FLHiH0VMAaXngZ9xK4fxT+3w/JO6wm1dHc5f P8DDymRsMcE+mSRstLK/H8DVn96DQrZbFQjEXOi0vrCg0+OrjqOOz3q1F8L8YtJSsyQo ZUqLsuNjGPmTEHP1SSXj/Fjwozq+fCTgSsFP1REckJvCYVP+/ENvaM8lfCoEmmUEft3i k6juegJ0t7BX2Q1H2+4y0NnzV+14pnVHoHDAU9V/Iqh7FE7paFYYcKv8TSSOuvVMzw6Z lA3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681899756; x=1684491756; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fU2wrMIC42PqEyjIjG+AcTqJMu7tdAgxZ3YGA63S+ss=; b=iCbrp7kZEd17PRl+SKMi1aKWnEmgOoJYdFTnJ3H/A1M3JN/9y/2PMe7Aq6unJlpct0 8iKwuZZDYVTYxwGtyQbx/qXwmMDE1PyWrZq6Qpe6VPnaz/MOD4ST9Fa62Qttqr+swcF9 6BgPkda3t0cY5C7Mgx81+GSohc+roUsU9hb+deTqQLdA/KwK1kvB8y5SEgqpT6TSx+4q 6I761Dt2R2D1+L2fWlnhmy2BMCuv+tmV/C4F93R/mSw7bfE48Mq9gFk1X2TRgnP0akZi K8CD+oQ3wD56q88pV04ARcVPxq5FOxzB2Yhp2NNaIJya14C0RDRb4q4oaJ4BF6cDHR0W sj/g== X-Gm-Message-State: AAQBX9ePaLipqeug2if8DQmUkbpws7oMU83Mvka/sWhjbCxiQ5Dp/vx8 VJhlds+eJhApxqVsoCHBRxVzuA== X-Google-Smtp-Source: AKy350adVq+0Enif94wp4RhcZ0STlydhZB7rHzAw+LUwH+tkkZJ5nZxGpmn1sKzin3LOW8z9QJJ8Jg== X-Received: by 2002:a05:600c:284:b0:3f1:819d:d046 with SMTP id 4-20020a05600c028400b003f1819dd046mr1102778wmk.5.1681899756569; Wed, 19 Apr 2023 03:22:36 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:1360:9fbb:dfd6:2db4? ([2a01:e0a:982:cbb0:1360:9fbb:dfd6:2db4]) by smtp.gmail.com with ESMTPSA id s9-20020a5d6a89000000b002cf1c435afcsm15475539wru.11.2023.04.19.03.22.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Apr 2023 03:22:36 -0700 (PDT) Message-ID: <2804f8ba-e0c5-554b-645b-20320fda89ae@linaro.org> Date: Wed, 19 Apr 2023 12:22:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [RFC PATCH 1/2] arm64: amlogic: add new ARCH_AMLIPC for IPC SoC Content-Language: en-US To: =Xianwei Zhao , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org Cc: Catalin Marinas , Will Deacon , Kevin Hilman , Rob Herring , Krzysztof Kozlowski References: <20230419073834.972273-1-xianwei.zhao@amlogic.com> <20230419073834.972273-2-xianwei.zhao@amlogic.com> Organization: Linaro Developer Services In-Reply-To: <20230419073834.972273-2-xianwei.zhao@amlogic.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 19/04/2023 09:38, =Xianwei Zhao wrote: > From: Xianwei Zhao > > The C series SoCs are designed for smart IP camera > applications, which does not belong to Meson series. > So, Add ARCH_AMLIPC for the new series. > > There are now multiple amlogic SoC seies supported, so group them under > their own menu. we can easily add new platforms there in the future. > Introduce ARCH_AMLOGIC to cover all Amlogic SoC series. There's no strong reason to add a new ARCH here, apart willing to kill the MESON name, but it's usual to keep a arch naming from the first SoC family supported, it doesn't mean the new aren't supported or whatever, it's only a simple config name. I understand the new SoCs are a new family, but they still share a lot of IPs and driver that are present and supported on the Meson SoCs. Please concentrate on adding the DTs and compatibles, changing the current config and driver names is low priority unless there's a really strong reason. It's perfectly ok to drop meson for new configs, new driver & new bindings, and it's already the case for the A1 SPIFC driver and most new G12/SM1 compatibles. Neil > > No functional changes introduced. > > Signed-off-by: Xianwei Zhao > --- > arch/arm64/Kconfig.platforms | 12 ++++++++++++ > arch/arm64/configs/defconfig | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 89a0b13b058d..bfbc817eef8f 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -162,12 +162,24 @@ config ARCH_MEDIATEK > This enables support for MediaTek MT27xx, MT65xx, MT76xx > & MT81xx ARMv8 SoCs > > +menuconfig ARCH_AMLOGIC > + bool "NXP SoC support" > + > +if ARCH_AMLOGIC > + > config ARCH_MESON > bool "Amlogic Platforms" > help > This enables support for the arm64 based Amlogic SoCs > such as the s905, S905X/D, S912, A113X/D or S905X/D2 > > +config ARCH_AMLIPC > + bool "Amlogic IPC Platforms" > + help > + This enables support for the arm64 based Amlogic IPC SoCs > + such as the C302X, C308L > +endif > + > config ARCH_MVEBU > bool "Marvell EBU SoC Family" > select ARMADA_AP806_SYSCON > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 7790ee42c68a..f231bd1723fd 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -46,7 +46,9 @@ CONFIG_ARCH_LG1K=y > CONFIG_ARCH_HISI=y > CONFIG_ARCH_KEEMBAY=y > CONFIG_ARCH_MEDIATEK=y > +CONFIG_ARCH_AMLOGIC=y > CONFIG_ARCH_MESON=y > +CONFIG_ARCH_AMLIPC=y > CONFIG_ARCH_MVEBU=y > CONFIG_ARCH_NXP=y > CONFIG_ARCH_LAYERSCAPE=y