From: Krzysztof Kozlowski <krzk@kernel.org>
To: Frank Wang <frawang.cn@gmail.com>,
vkoul@kernel.org, kishon@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de
Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
william.wu@rock-chips.com, tim.chen@rock-chips.com,
frank.wang@rock-chips.com
Subject: Re: [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576
Date: Fri, 27 Sep 2024 11:52:48 +0200 [thread overview]
Message-ID: <2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org> (raw)
In-Reply-To: <a06af01a-656b-4ef6-84a6-bc1c35d5bafa@gmail.com>
On 27/09/2024 09:59, Frank Wang wrote:
>>>
>>> - clocks:
>>> - maxItems: 1
>>> + clocks: true
>>>
>>> - clock-names:
>>> - const: phyclk
>>> + clock-names: true
>> For the third time, read the code I gave you. Do you see something like
>> this there? Why doing all the time something different than existing code?
>
> Refer to the link you sent me that I must add minItems property for
> clocks, just like the below codes:
>
> @@ -35,7 +35,8 @@ properties:
> const: 0
>
> clocks:
> - maxItems: 1
> + minItems: 1
> + maxItems: 3
Yes, for all variable properties, so also names.
>
> That can pass dt_binding and dtb checking, however, "clocks" is the
> optional property for some old Rockchip PHYs, I am not sure is it right
> to force set minItems as 1 .
> If just keep maxItems, the dt_binding checking is failure.
Please specify the question you want to ask.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-27 9:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:32 [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 Frank Wang
2024-09-26 10:32 ` [PATCH v3 2/2] phy: rockchip: inno-usb2: Add usb2 phys support for rk3576 Frank Wang
2024-09-26 10:48 ` Heiko Stuebner
2024-09-27 6:16 ` Frank Wang
2024-09-27 7:42 ` Heiko Stuebner
2024-09-26 14:19 ` [PATCH v3 1/2] dt-bindings: phy: rockchip,inno-usb2phy: add rk3576 Krzysztof Kozlowski
2024-09-27 7:01 ` Frank Wang
2024-09-27 7:30 ` Krzysztof Kozlowski
2024-09-27 7:59 ` Frank Wang
2024-09-27 9:52 ` Krzysztof Kozlowski [this message]
2024-09-27 10:49 ` Frank Wang
2024-09-27 10:59 ` Frank Wang
2024-09-27 12:05 ` Krzysztof Kozlowski
2024-09-27 8:02 ` Heiko Stuebner
2024-09-27 9:56 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2815219e-3a20-4a5b-8573-d8a4ad2df1c9@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.wang@rock-chips.com \
--cc=frawang.cn@gmail.com \
--cc=heiko@sntech.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=tim.chen@rock-chips.com \
--cc=vkoul@kernel.org \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).