From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88649C433F5 for ; Sat, 26 Feb 2022 18:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232173AbiBZSJl (ORCPT ); Sat, 26 Feb 2022 13:09:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230391AbiBZSJl (ORCPT ); Sat, 26 Feb 2022 13:09:41 -0500 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC2493EB9D; Sat, 26 Feb 2022 10:09:04 -0800 (PST) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nO1Ux-0008U9-7Z; Sat, 26 Feb 2022 19:08:51 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: linux-rockchip@lists.infradead.org, Frank Wunderlich Cc: Frank Wunderlich , Rob Herring , Krzysztof Kozlowski , Peter Geis , Michael Riesch , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] arm64: dts: rockchip: Add sata2 node to rk356x Date: Sat, 26 Feb 2022 19:08:50 +0100 Message-ID: <2815432.3mA4caTK8C@diego> In-Reply-To: <20220226135724.61516-1-linux@fw-web.de> References: <20220226135724.61516-1-linux@fw-web.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Frank, Am Samstag, 26. Februar 2022, 14:57:24 CET schrieb Frank Wunderlich: > From: Frank Wunderlich > > RK356x supports up to 3 sata controllers which were compatible with the > existing snps,dwc-ahci binding. > > My board has only sata2 connected to combphy2 so only add this one. how far does the added node diverge from the vendor kernel? If it's pretty much similar between both, we can assume the other nodes should work pretty well as well and therefore should all of them at once and hope for the best? Thanks Heiko > Signed-off-by: Frank Wunderlich > --- > arch/arm64/boot/dts/rockchip/rk356x.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > index 7cdef800cb3c..7b6c8a0c8b84 100644 > --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi > @@ -230,6 +230,21 @@ scmi_shmem: sram@0 { > }; > }; > > + sata2: sata@fc800000 { > + compatible = "snps,dwc-ahci"; > + reg = <0 0xfc800000 0 0x1000>; > + clocks = <&cru ACLK_SATA2>, <&cru CLK_SATA2_PMALIVE>, > + <&cru CLK_SATA2_RXOOB>; > + clock-names = "sata", "pmalive", "rxoob"; > + interrupts = ; > + interrupt-names = "hostc"; > + phys = <&combphy2 PHY_TYPE_SATA>; > + phy-names = "sata-phy"; > + ports-implemented = <0x1>; > + power-domains = <&power RK3568_PD_PIPE>; > + status = "disabled"; > + }; > + > gic: interrupt-controller@fd400000 { > compatible = "arm,gic-v3"; > reg = <0x0 0xfd400000 0 0x10000>, /* GICD */ >