From: Krzysztof Kozlowski <krzk@kernel.org>
To: Julien Massot <julien.massot@collabora.com>,
devicetree@vger.kernel.org, linux-media@vger.kernel.org
Cc: kernel@collabora.com
Subject: Re: [PATCH v2 3/4] media: i2c: add MAX96714 driver
Date: Mon, 8 Jan 2024 19:58:59 +0100 [thread overview]
Message-ID: <2815d883-3f0d-483d-a8ac-da9941245727@kernel.org> (raw)
In-Reply-To: <3da48ce6-52fb-482d-ad23-e59adeb51c32@collabora.com>
On 08/01/2024 14:20, Julien Massot wrote:
>>> +static int max96714_get_hw_resources(struct max96714_priv *priv)
>>> +{
>>> + struct device *dev = &priv->client->dev;
>>> +
>>> + priv->regmap = devm_regmap_init_i2c(priv->client,
>>> + &max96714_regmap_config);
>>> + if (IS_ERR(priv->regmap))
>>> + return PTR_ERR(priv->regmap);
>>> +
>>> + priv->gpiod_pwdn = devm_gpiod_get_optional(&priv->client->dev, "enable",
>>> + GPIOD_OUT_HIGH);
>>> + if (IS_ERR(priv->gpiod_pwdn))
>>> + return dev_err_probe(dev, PTR_ERR(priv->gpiod_pwdn),
>>
>> A powerdown GPIO is not an enable GPIO. Please use correct name - see
>> gpio-consumers-common.yaml
> Ok I will rename it 'pwdn' instead.
Did you open that file and read it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-08 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 14:33 [PATCH v2 0/4] Add support for MAX96714F and MAX96717F GMSL2 ser/des Julien Massot
2023-12-08 14:33 ` [PATCH v2 1/4] dt-bindings: media: add Maxim MAX96714F GMSL2 Deserializer Julien Massot
2023-12-08 15:29 ` Rob Herring
2023-12-08 17:16 ` Krzysztof Kozlowski
2024-01-08 13:17 ` Julien Massot
2023-12-08 14:33 ` [PATCH v2 2/4] dt-bindings: media: add Maxim MAX96717F GMSL2 Serializer Julien Massot
2023-12-08 15:29 ` Rob Herring
2023-12-08 17:17 ` Krzysztof Kozlowski
2023-12-08 14:33 ` [PATCH v2 3/4] media: i2c: add MAX96714 driver Julien Massot
2023-12-08 17:18 ` Krzysztof Kozlowski
2024-01-08 13:20 ` Julien Massot
2024-01-08 18:58 ` Krzysztof Kozlowski [this message]
2023-12-09 15:54 ` kernel test robot
2023-12-10 2:13 ` kernel test robot
2023-12-08 14:33 ` [PATCH v2 4/4] media: i2c: add MAX96717 driver Julien Massot
2023-12-09 4:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2815d883-3f0d-483d-a8ac-da9941245727@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).