devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	linux-pwm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Milo Kim <milo.kim@ti.com>,
	Doug Anderson <dianders@google.com>,
	Caesar Wang <wxt@rock-chips.com>,
	Stephen Barber <smbarber@chromium.org>,
	Brian Norris <briannorris@chromium.org>,
	Ajit Pal Singh <ajitpal.singh@st.com>,
	Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
	Maxime Coquelin <maxime.coquelin@st.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	kernel@stlinux.com, Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [PATCH v2 00/13] regulator: pwm: various improvements
Date: Thu, 09 Jun 2016 20:04:20 +0200	[thread overview]
Message-ID: <2819222.JTKrccvLNL@diego> (raw)
In-Reply-To: <1465403688-17098-1-git-send-email-boris.brezillon@free-electrons.com>

Hi Boris,

Am Mittwoch, 8. Juni 2016, 18:34:35 schrieb Boris Brezillon:
> This patch series series aims at adding two important features to the
> pwm-regulator driver.
> 
> The first one is the support for 'smooth handover' between the
> bootloader and the kernel. This is mainly solving problems we have when
> the PWM is controlling a critical regulator (like the one powering the
> DDR chip). Currently, when the PWM regulator acquire the PWM device it
> assumes it was off and it's safe to change the configuration before
> enabling it, which can generate glitches on the PWM signal which in turn
> generated glitches on the output voltage.
> To solve that we've introduced support for hardware readout to the
> PWM framework, so that the PWM regulator driver can adjust the PWM
> a probe time and avoid glitches.
> Atomic update is also helping in this regard.

[...]

> The second feature we add to the driver is the capability of using
> a sub duty_cycle range in continuous mode. By default the regulator
> is assuming that min_uV is achieved with a 0% dutycyle and max_uV
> with a 100% dutycycle, but this is not necessarily true.
> Moreover, in some cases (when the PWM device does not support
> polarity inversion), we might have min_uV at 100% and max_uV at 0%.
> Hence the addition of new properties to the existing DT bindings.
> The feature is added in patch 12 and 13.

I've tested this series on a rk3288-veyron chromebook and both the backlight-
pwm as well as the pwm-regulator still work as expected, so for everything 
except the STI parts:

Tested-by: Heiko Stuebner <heiko@sntech.de>

      parent reply	other threads:[~2016-06-09 18:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08 16:34 [PATCH v2 00/13] regulator: pwm: various improvements Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 01/13] pwm: Add new helpers to create/manipulate PWM states Boris Brezillon
2016-06-10 15:21   ` Thierry Reding
2016-06-10 16:29     ` Boris Brezillon
2016-06-10 16:47       ` Thierry Reding
     [not found] ` <1465403688-17098-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-08 16:34   ` [PATCH v2 02/13] pwm: rockchip: Fix period and duty_cycle approximation Boris Brezillon
2016-06-08 16:34   ` [PATCH v2 03/13] pwm: rockchip: Add support for hardware readout Boris Brezillon
2016-06-08 16:34   ` [PATCH v2 04/13] pwm: rockchip: Avoid glitches on already running PWMs Boris Brezillon
2016-06-08 16:34   ` [PATCH v2 05/13] pwm: rockchip: Add support for atomic update Boris Brezillon
2016-06-08 16:34   ` [PATCH v2 07/13] pwm: sti: Avoid glitches on already running PWMs Boris Brezillon
2016-06-08 16:34   ` [PATCH v2 08/13] regulator: pwm: Adjust PWM config at probe time Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 06/13] pwm: sti: Add support for hardware readout Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 09/13] regulator: pwm: Switch to the atomic PWM API Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 10/13] regulator: pwm: Properly initialize the ->state field Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 11/13] regulator: pwm: Retrieve correct voltage Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 12/13] regulator: pwm: Support extra continuous mode cases Boris Brezillon
2016-06-08 16:34 ` [PATCH v2 13/13] regulator: pwm: Document pwm-dutycycle-unit and pwm-dutycycle-range Boris Brezillon
2016-06-10 14:06   ` Rob Herring
2016-06-09 18:04 ` Heiko Stübner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2819222.JTKrccvLNL@diego \
    --to=heiko@sntech.de \
    --cc=ajitpal.singh@st.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@stlinux.com \
    --cc=ldewangan@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.coquelin@st.com \
    --cc=milo.kim@ti.com \
    --cc=patrice.chotard@st.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=smbarber@chromium.org \
    --cc=srinivas.kandagatla@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).