From: Arnd Bergmann <arnd@arndb.de>
To: Phil Reid <preid@electromag.com.au>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
peppe.cavallaro@st.com, davem@davemloft.net,
vbridger@opensource.altera.com, devicetree@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 1/4] stmmac: create of compatible mdio bus for stmacc driver
Date: Tue, 08 Dec 2015 10:35:05 +0100 [thread overview]
Message-ID: <2819989.unjINxCo2S@wuerfel> (raw)
In-Reply-To: <1449551582-6599-2-git-send-email-preid@electromag.com.au>
On Tuesday 08 December 2015 13:12:59 Phil Reid wrote:
> @@ -201,6 +201,25 @@ int stmmac_mdio_register(struct net_device *ndev)
> struct stmmac_mdio_bus_data *mdio_bus_data = priv->plat->mdio_bus_data;
> int addr, found;
>
> +#ifdef CONFIG_OF
> + struct device_node *mdio_node = NULL;
> + struct device_node *child_node = NULL;
> +
> + for_each_child_of_node(priv->device->of_node, child_node) {
> + if (of_device_is_compatible(child_node, "snps,dwmac-mdio")) {
> + mdio_node = child_node;
> + break;
> + }
> + }
Can you use "if (IS_ENABLED(CONFIG_OF))" here instead of a preprocessor "#if"?
> @@ -231,7 +250,11 @@ int stmmac_mdio_register(struct net_device *ndev)
> new_bus->irq = irqlist;
> new_bus->phy_mask = mdio_bus_data->phy_mask;
> new_bus->parent = priv->device;
> +#ifdef CONFIG_OF
> + err = of_mdiobus_register(new_bus, mdio_node);
> +#else
> err = mdiobus_register(new_bus);
> +#endif
This looks like it should be done in the header file. Can you make
a separate patch that changes the header file declaring of_mdiobus_register
to make it a static inline function calling mdiobus_register() if CONFIG_OF
is disabled?
Arnd
next prev parent reply other threads:[~2015-12-08 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-08 5:12 [PATCH v3 0/4] stmmac: Fixed Phy & PTP fixes Phil Reid
2015-12-08 5:12 ` [PATCH v3 1/4] stmmac: create of compatible mdio bus for stmacc driver Phil Reid
2015-12-08 9:35 ` Arnd Bergmann [this message]
2015-12-08 10:53 ` Tobias Klauser
2015-12-08 5:13 ` [PATCH v3 2/4] stmmac: Correct documentation on stmmac clocks Phil Reid
[not found] ` <1449551582-6599-1-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
2015-12-08 5:13 ` [PATCH v3 3/4] stmmac: Fix calculations for ptp counters when clock input = 50Mhz Phil Reid
2015-12-08 5:13 ` [PATCH v3 4/4] stmmac: socfpga: Provide dt node to config ptp clk source Phil Reid
2015-12-09 3:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2819989.unjINxCo2S@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=preid@electromag.com.au \
--cc=robh+dt@kernel.org \
--cc=vbridger@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).