From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598F91552E0; Wed, 25 Sep 2024 08:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727253793; cv=none; b=hzhgx+48/mFtEG/EMRoV1lmMVsjcqnBz1cN5tkH5XWWgxDmTLwnKrfRTXZYmvVJNLc1yCNEELVzbSiJebVb/Iu8mUF2k3+HCWN4Jfd1yisYIObUczPU5B3hJh1YgiTF1cggxMd4/K+Amv2V6c8mGc0cXxr2GnmgnJoRmjD/abuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727253793; c=relaxed/simple; bh=dI3IZSn8QJ5+D9rEhSc0z1pZ65+OKrZFPZp75fmOL3c=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=N7ZXp4BzEklVosN6lA5c9ixmSZbktNSmjKIqlH+79jqcqC2JHPUdPSrL3Vl2aLKpbuyVVDa0gxjitcY1vgkFKhd878X0qKBZATxQqU+aR0+dFCqgLKsibm4nZZHIcvZHjQlNvYL0eWj5VTT8p9bwoRAkVLWYs9yGJtXjkc3vkuo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=Mo1xlRuh; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="Mo1xlRuh" X-UUID: 2e3b99f87b1a11ef8b96093e013ec31c-20240925 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID; bh=JrbVtDLJwECuyvPhK0BEV+KwQsj0q8fI1QSWfwxU1nE=; b=Mo1xlRuhAzQobwoV5qygzF6o/nRQm+uZy6LeTFM2p3IOe2WmHz6dsVeJDNQbeqrZu2gPYXicr/MSNhpy55dcIABLvsLL23jFUDrnZdl2OYLehbx+lg+ZudLnvhKEw0lxcgDzu71I3eNwWoyKf2q/faCnTKGXIBth+2ei7hBHJKw=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.41,REQID:664a495c-7254-4e32-b0a8-7a062548c705,IP:0,U RL:0,TC:0,Content:8,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:8 X-CID-META: VersionHash:6dc6a47,CLOUDID:7490899e-8e9a-4ac1-b510-390a86b53c0a,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:4|-5,EDM:-3,IP:ni l,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES :1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 2e3b99f87b1a11ef8b96093e013ec31c-20240925 Received: from mtkmbs09n2.mediatek.inc [(172.21.101.94)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2138599595; Wed, 25 Sep 2024 16:43:04 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Wed, 25 Sep 2024 16:43:02 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Wed, 25 Sep 2024 16:43:01 +0800 Message-ID: <2821ef09-1b32-082d-69d1-e09a3a302447@mediatek.com> Date: Wed, 25 Sep 2024 16:42:59 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/6] dt-bindings: display: mediatek: Fix clocks count constraint for new SoCs Content-Language: en-US To: Conor Dooley , AngeloGioacchino Del Regno , , CC: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Matthias Brugger , , , , , , , Alexandre Mergnat , Bear Wang , Pablo Sun , Macpaul Lin , Sen Chu , Chris-qj chen , "MediaTek Chromebook Upstream" , Chen-Yu Tsai References: <20240924103156.13119-1-macpaul.lin@mediatek.com> <20240924103156.13119-3-macpaul.lin@mediatek.com> <20240924-commute-collision-13ad39717d31@spud> From: Macpaul Lin In-Reply-To: <20240924-commute-collision-13ad39717d31@spud> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-Product-Ver: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-AS-Result: No-10--11.313000-8.000000 X-TMASE-MatchedRID: QfHZjzml1E8OwH4pD14DsPHkpkyUphL9Wot5Z16+u76+UkTh6A/DwT8f ilvi6fr90mFsFMx0VZMOYgThO+DmXx2P280ZiGmRdARARTk4h59bAoaK+wS4jRSX1u8BLtZAFRE 6l+a4SRTiTN0gJqFURMzVnE1oQDqoavi5Lq9+Ha1s7yIvC2pwGtF9F+XaXgXeZ5yuplze9ptTyk OINBDQU+cQv6iXuAzrwVMUpfyfKUIAwWnlblYdAsxmTzofEWOOazzS+36ix9ybKItl61J/ycnjL TA/UDoAA6QGdvwfwZZWRVlrjsKO8N0H8LFZNFG7bkV4e2xSge75AqQykow+yePbmdtfeypRXtRV FLwJOwOr2TwTTCELzrAUyUg9ogFt X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--11.313000-8.000000 X-TMASE-Version: SMEX-14.0.0.3152-9.1.1006-23728.005 X-TM-SNTS-SMTP: 972967CB0576905A235A1CA79982300AA079E3A940A8E8B2F8C6AB1ADA60F2932000:8 On 9/25/24 00:00, Conor Dooley wrote: > On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del Regno wrote: >> Il 24/09/24 12:31, Macpaul Lin ha scritto: >>> The display node in mt8195.dtsi was triggering a CHECK_DTBS error due >>> to an excessively long 'clocks' property: >>> display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long >>> >>> To resolve this issue, add "maxItems: 3" to the 'clocks' property in >>> the DT schema. >>> >>> Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each block to individual yaml") >>> Signed-off-by: Macpaul Lin >>> --- >>> .../devicetree/bindings/display/mediatek/mediatek,split.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>> index e4affc854f3d..42d2d483cc29 100644 >>> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml >>> @@ -57,6 +57,7 @@ properties: >>> clocks: >>> items: >>> - description: SPLIT Clock >> >> That's at least confusing (granted that it works) - either add a description for >> each clock and then set `minItems: 1` (preferred), or remove this "SPLIT Clock" >> description and allow a maximum of 3 clocks. >> >> Removing the description can be done - IMO - because "SPLIT Clock" is, well, >> saying that the SPLIT block gets a SPLIT clock ... stating the obvious, anyway. > > Right, but what are the other two new clocks? Are they as obvious? > There's no clock-names here to give any more information as to what the > other clocks are supposed to be. > > Kinda unrelated, but I think that "SPLIT Clock" probably isn't what the > name of the clock in the IP block is anyway, sounds more like the name > for it on the provider end.. Thanks for the suggestions. I think Moudy could help on the new fixes for both DT schem and mt8195.dtsi. This patch could be separated from origin patch set. Thanks Macpaul Lin