* [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible
@ 2024-01-31 11:23 Siddharth Vadapalli
2024-01-31 16:13 ` Andrew Davis
0 siblings, 1 reply; 5+ messages in thread
From: Siddharth Vadapalli @ 2024-01-31 11:23 UTC (permalink / raw)
To: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt
Cc: devicetree, linux-kernel, linux-arm-kernel, afd, srk, s-vadapalli
The PCIE_CTRL registers within the CTRL_MMR space of TI's K3 SoCs are
used to configure the link speed, lane count and mode of operation of
the respective PCIe instance. Add compatible for allowing the PCIe
driver to obtain a regmap for the PCIE_CTRL register within the System
Controller device-tree node in order to configure the PCIe instance
accordingly.
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
This patch is based on linux-next tagged next-20240131.
Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 084b5c2a2a3c..da571a24e21f 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -73,6 +73,7 @@ properties:
- rockchip,rv1126-qos
- starfive,jh7100-sysmain
- ti,am654-dss-oldi-io-ctrl
+ - ti,k3-pcie-ctrl
- const: syscon
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible
2024-01-31 11:23 [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible Siddharth Vadapalli
@ 2024-01-31 16:13 ` Andrew Davis
2024-02-01 4:48 ` Siddharth Vadapalli
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Davis @ 2024-01-31 16:13 UTC (permalink / raw)
To: Siddharth Vadapalli, lee, robh+dt, krzysztof.kozlowski+dt,
conor+dt
Cc: devicetree, linux-kernel, linux-arm-kernel, srk
On 1/31/24 5:23 AM, Siddharth Vadapalli wrote:
> The PCIE_CTRL registers within the CTRL_MMR space of TI's K3 SoCs are
> used to configure the link speed, lane count and mode of operation of
> the respective PCIe instance. Add compatible for allowing the PCIe
> driver to obtain a regmap for the PCIE_CTRL register within the System
> Controller device-tree node in order to configure the PCIe instance
> accordingly.
>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> ---
>
> This patch is based on linux-next tagged next-20240131.
>
> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 084b5c2a2a3c..da571a24e21f 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -73,6 +73,7 @@ properties:
> - rockchip,rv1126-qos
> - starfive,jh7100-sysmain
> - ti,am654-dss-oldi-io-ctrl
> + - ti,k3-pcie-ctrl
This might not be the same for all K3 devices, you should use
the name of the first device which uses this, so:
ti,j721e-pcie-ctrl
Andrew
>
> - const: syscon
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible
2024-01-31 16:13 ` Andrew Davis
@ 2024-02-01 4:48 ` Siddharth Vadapalli
2024-02-01 7:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Siddharth Vadapalli @ 2024-02-01 4:48 UTC (permalink / raw)
To: Andrew Davis
Cc: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-kernel, linux-arm-kernel, srk, s-vadapalli
Hello Andrew,
On 31/01/24 21:43, Andrew Davis wrote:
> On 1/31/24 5:23 AM, Siddharth Vadapalli wrote:
>> The PCIE_CTRL registers within the CTRL_MMR space of TI's K3 SoCs are
>> used to configure the link speed, lane count and mode of operation of
>> the respective PCIe instance. Add compatible for allowing the PCIe
>> driver to obtain a regmap for the PCIE_CTRL register within the System
>> Controller device-tree node in order to configure the PCIe instance
>> accordingly.
>>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> ---
>>
>> This patch is based on linux-next tagged next-20240131.
>>
>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 084b5c2a2a3c..da571a24e21f 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -73,6 +73,7 @@ properties:
>> - rockchip,rv1126-qos
>> - starfive,jh7100-sysmain
>> - ti,am654-dss-oldi-io-ctrl
>> + - ti,k3-pcie-ctrl
>
> This might not be the same for all K3 devices, you should use
> the name of the first device which uses this, so:
>
> ti,j721e-pcie-ctrl
It is the same for all K3 devices so far. However, since the convention appears
to be the first device that it is applicable to as you pointed out, I will post
the v2 patch for this accordingly.
--
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible
2024-02-01 4:48 ` Siddharth Vadapalli
@ 2024-02-01 7:31 ` Krzysztof Kozlowski
2024-02-01 9:02 ` Siddharth Vadapalli
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-01 7:31 UTC (permalink / raw)
To: Siddharth Vadapalli, Andrew Davis
Cc: lee, robh+dt, krzysztof.kozlowski+dt, conor+dt, devicetree,
linux-kernel, linux-arm-kernel, srk
On 01/02/2024 05:48, Siddharth Vadapalli wrote:
> Hello Andrew,
>
> On 31/01/24 21:43, Andrew Davis wrote:
>> On 1/31/24 5:23 AM, Siddharth Vadapalli wrote:
>>> The PCIE_CTRL registers within the CTRL_MMR space of TI's K3 SoCs are
>>> used to configure the link speed, lane count and mode of operation of
>>> the respective PCIe instance. Add compatible for allowing the PCIe
>>> driver to obtain a regmap for the PCIE_CTRL register within the System
>>> Controller device-tree node in order to configure the PCIe instance
>>> accordingly.
>>>
>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>> ---
>>>
>>> This patch is based on linux-next tagged next-20240131.
>>>
>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> index 084b5c2a2a3c..da571a24e21f 100644
>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>> @@ -73,6 +73,7 @@ properties:
>>> - rockchip,rv1126-qos
>>> - starfive,jh7100-sysmain
>>> - ti,am654-dss-oldi-io-ctrl
>>> + - ti,k3-pcie-ctrl
>>
>> This might not be the same for all K3 devices, you should use
>> the name of the first device which uses this, so:
>>
>> ti,j721e-pcie-ctrl
>
> It is the same for all K3 devices so far. However, since the convention appears
> to be the first device that it is applicable to as you pointed out, I will post
> the v2 patch for this accordingly.
This was repeated so many times... so one more. Compatibles are specific
to SoC, not to family.
https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible
2024-02-01 7:31 ` Krzysztof Kozlowski
@ 2024-02-01 9:02 ` Siddharth Vadapalli
0 siblings, 0 replies; 5+ messages in thread
From: Siddharth Vadapalli @ 2024-02-01 9:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andrew Davis, lee, robh+dt, krzysztof.kozlowski+dt, conor+dt,
devicetree, linux-kernel, linux-arm-kernel, srk, s-vadapalli
Hello Krzysztof,
On 01/02/24 13:01, Krzysztof Kozlowski wrote:
> On 01/02/2024 05:48, Siddharth Vadapalli wrote:
>> Hello Andrew,
>>
>> On 31/01/24 21:43, Andrew Davis wrote:
>>> On 1/31/24 5:23 AM, Siddharth Vadapalli wrote:
>>>> The PCIE_CTRL registers within the CTRL_MMR space of TI's K3 SoCs are
>>>> used to configure the link speed, lane count and mode of operation of
>>>> the respective PCIe instance. Add compatible for allowing the PCIe
>>>> driver to obtain a regmap for the PCIE_CTRL register within the System
>>>> Controller device-tree node in order to configure the PCIe instance
>>>> accordingly.
>>>>
>>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>>> ---
>>>>
>>>> This patch is based on linux-next tagged next-20240131.
>>>>
>>>> Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> index 084b5c2a2a3c..da571a24e21f 100644
>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> @@ -73,6 +73,7 @@ properties:
>>>> - rockchip,rv1126-qos
>>>> - starfive,jh7100-sysmain
>>>> - ti,am654-dss-oldi-io-ctrl
>>>> + - ti,k3-pcie-ctrl
>>>
>>> This might not be the same for all K3 devices, you should use
>>> the name of the first device which uses this, so:
>>>
>>> ti,j721e-pcie-ctrl
>>
>> It is the same for all K3 devices so far. However, since the convention appears
>> to be the first device that it is applicable to as you pointed out, I will post
>> the v2 patch for this accordingly.
>
> This was repeated so many times... so one more. Compatibles are specific
> to SoC, not to family.
>
> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42
Thank you for reviewing the patch and sharing your feedback. I will make sure
not to repeat this in my future patches.
--
Regards,
Siddharth.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-02-01 9:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-31 11:23 [PATCH] dt-bindings: mfd: syscon: Add ti,k3-pcie-ctrl compatible Siddharth Vadapalli
2024-01-31 16:13 ` Andrew Davis
2024-02-01 4:48 ` Siddharth Vadapalli
2024-02-01 7:31 ` Krzysztof Kozlowski
2024-02-01 9:02 ` Siddharth Vadapalli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).