From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C13C77B75 for ; Tue, 18 Apr 2023 14:12:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbjDROMX (ORCPT ); Tue, 18 Apr 2023 10:12:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231975AbjDROMU (ORCPT ); Tue, 18 Apr 2023 10:12:20 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 002BD14F62; Tue, 18 Apr 2023 07:12:11 -0700 (PDT) Received: from ip4d1634d3.dynamic.kabel-deutschland.de ([77.22.52.211] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pom3u-0003l7-Rd; Tue, 18 Apr 2023 16:12:02 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Johan Jonker , Daniel Lezcano , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Sebastian Reichel , Sugar Zhang , Shreeya Patel , Kever Yang , Cristian Ciocaltea Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add rk3588 timer Date: Tue, 18 Apr 2023 16:12:01 +0200 Message-ID: <2828868.BjyWNHgNrj@diego> In-Reply-To: References: <20230418095344.274025-1-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am Dienstag, 18. April 2023, 13:53:23 CEST schrieb Cristian Ciocaltea: > > On 4/18/23 14:29, Johan Jonker wrote: > > > > > > On 4/18/23 11:53, Cristian Ciocaltea wrote: > >> Add DT node for Rockchip RK3588/RK3588S SoC timer. > >> > >> Signed-off-by: Cristian Ciocaltea > >> --- > >> arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > >> index 657c019d27fa..acd89a55374a 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi > >> @@ -1400,6 +1400,14 @@ i2c5: i2c@fead0000 { > >> status = "disabled"; > >> }; > >> > > > >> + rktimer: timer@feae0000 { > > > > There are multiple timers. > > Use a label in line with the TRM. > > Maybe change your label to "timer0" in that trend? > > Sure, will use "timer0". > > >> + compatible = "rockchip,rk3588-timer", "rockchip,rk3288-timer"; > >> + reg = <0x0 0xfeae0000 0x0 0x20>; > > > >> + clocks = <&cru PCLK_BUSTIMER0>, <&cru CLK_BUSTIMER0>; > >> + clock-names = "pclk", "timer"; > >> + interrupts = ; > > > > Heiko's sort rules: > > > > compatible > > reg > > interrupts > > [alphabetical] > > status [if needed] > > Thanks for pointing this out! The sort rule was not obvious as there are > many other nodes that don't conform. hmm, that is probably an oversight then :-) . Though looking through rk3588s.dtsi and rk3588.dtsi, it looks like most peripherals follow that sorting quite nicely. But there is also a bit of leeway ... aka there can be an argument made that assigned-clocks might want to live near clocks or regulator-properties could be sorted somewhat differently. So general ideal is alphabetically for the random properties to give some guidance on sorting. And compatible, regs, interrupts at the top + status at the bottom makes it way easier to establish a reading pattern, when looking for something in the file :-) . Heiko