From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/9] ARM: dts: exynos: Add macros for GPIO configuration Date: Wed, 31 Aug 2016 14:42:57 +0200 Message-ID: <28320955.k33BrW2NEN@wuerfel> References: <1472645613-5362-1-git-send-email-k.kozlowski@samsung.com> <1472645613-5362-2-git-send-email-k.kozlowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1472645613-5362-2-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Krzysztof Kozlowski , Rob Herring , Mark Rutland , Kukjin Kim , Krzysztof Kozlowski , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Javier Martinez Canillas , Tomasz Figa , Sylwester Nawrocki , Bartlomiej Zolnierkiewicz List-Id: devicetree@vger.kernel.org On Wednesday, August 31, 2016 2:13:25 PM CEST Krzysztof Kozlowski wrote: > > +#define PIN_PULL_NONE 0 > +#define PIN_PULL_DOWN 1 > +#define PIN_PULL_UP 3 > + > +#define PIN_DRV_LV1 0 > +#define PIN_DRV_LV2 2 > +#define PIN_DRV_LV3 1 > +#define PIN_DRV_LV4 3 > + > +#define PIN_FUNC_INPUT 0 > +#define PIN_FUNC_OUTPUT 1 > +#define PIN_FUNC_SPC_2 2 > +#define PIN_FUNC_SPC_3 3 > +#define PIN_FUNC_SPC_4 4 > +#define PIN_FUNC_SPC_5 5 > +#define PIN_FUNC_SPC_F 0xf Any reason for having a copy in each of those files instead of one that is shared across all of them? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html