Re: [PATCH v3 1/1] dt-bindings: rtc: nxp, pcf85063: Convert to DT schema

[Alexander Stein <alexander.stein@ew.tq-group.com>]

CC'ed Sam

Am Montag, 25. Juli 2022, 15:36:42 CEST schrieb Rob Herring:
> On Mon, 25 Jul 2022 09:19:19 +0200, Alexander Stein wrote:
> > Convert the NXP PCF85063 RTC binding to DT schema format.
> > 
> > Add 'interrupts' and 'wakeup-source' as this device has an interrupt
> > which was not documented, but is in use.
> > 'clock-output-names' and '#clock-cells' are added as well, those were
> > probably missed when adding clkout support in commit 8c229ab6048b
> > ("rtc: pcf85063: Add pcf85063 clkout control to common clock framework")
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Krzysztof, thanks for your review.
> > 
> > Changes in v3:
> > * Added constraints for rv8263 & pcf85063 regarding
> > 'quartz-load-femtofarads' * Fixed example
> > 
> > I have to admit I could not actually verify in the registers that pcf85063
> > is limited to 7pF. I was not able to find any datasheet containg the
> > registers, only a product brief [1] indicating this limit.
> > 
> > Changes in v2:
> > * Sorted compatible list
> > * Mentioned new #clock-cells and clock-output-names properties in commit
> > message * Removed 'interrupt-names', not needed/used anyway
> > * Fixed quartz-load-femtofarads defintion/description
> > 
> > [1] https://www.mouser.de/pdfDocs/NXP_PCF85063_PB.pdf
> > 
> >  .../devicetree/bindings/rtc/nxp,pcf85063.txt  | 32 -------
> >  .../devicetree/bindings/rtc/nxp,pcf85063.yaml | 92 +++++++++++++++++++
> >  2 files changed, 92 insertions(+), 32 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/rtc/nxp,pcf85063.txt
> >  create mode 100644
> >  Documentation/devicetree/bindings/rtc/nxp,pcf85063.yaml
> 
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
> 
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
> 
> Full log is available here: https://patchwork.ozlabs.org/patch/
> 
> 
> rtc@51: 'interrupt-names' does not match any of the regexes:
> 'pinctrl-[0-9]+' arch/arm64/boot/dts/freescale/imx8mq-tqma8mq-mba8mx.dtb

This is expected, patch for removal is already prepared.

> rtc@51: quartz-load-femtofarads:0:0: 7000 was expected
> 	arch/arm/boot/dts/imx6dl-skov-revc-lt2.dtb
> 	arch/arm/boot/dts/imx6dl-skov-revc-lt6.dtb
> 	arch/arm/boot/dts/imx6q-skov-revc-lt2.dtb
> 	arch/arm/boot/dts/imx6q-skov-revc-lt6.dtb
> 	arch/arm/boot/dts/imx6q-skov-reve-mi1010ait-1cp1.dtb

Oh, this is interesting. Sam, as the author of imx6q-skov, do you happen to 
know if "nxp,pcf85063" used in arch/arm/boot/dts/imx6qdl-skov-cpu.dtsi does 
actually support 12.5 pF?
Well, if in doubt I would rather remove this restriction.

Best regards,
Alexander