From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F398C25BAAE for ; Fri, 28 Feb 2025 10:10:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740737414; cv=none; b=NmAtWnX/7jVM7gpEdoJ2xAJEhrWyVtX94HL5rAbpLJUTY4zUY13LpStt+WEtsu1Enj24lvPaCn8meIE08mIR8sFO56AUqt7R6VndNhaUJJKYc8hyP5drP4W1Zwxxt9STKuxIpmF1Chh5O7eIeQz/AbOneAAJSA2Xg9Yby/nbhxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740737414; c=relaxed/simple; bh=Xpn6eY3pv3SpFbqjH4s4Z+vRVveEnSNNAdcO/1GAyM4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Yh7O+1RdTKWo/S66zRNTv6oKI4AaBfIixEncbw5zYTmMs1+jQgDrerG8n8l4BYRJU46YHZSnZudUxSn1MskVMBGtzgQAbSD8lbZjKXBF9APgPJ3SkRgIzXUQAw/ug4t6QtE+1mFHtZbS5IfvpCX5N6GP+NBX0WIZErwzIUlb6dM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=pZLVci7c; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=aSZkHu5t reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="pZLVci7c"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="aSZkHu5t" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1740737411; x=1772273411; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YE6bnB+P2s7EJv1Gtcomzzk1XsCHf5FrUL6+zsepQYk=; b=pZLVci7cb/EFevfYY3Pt8HhwUzvITWOU7KGHGv3a2UkWYgwelLVJWv1e myKK5cOKCDZI6eRAch3d3rgmUlw6iCByWl2b3AkV2eqMtuFF3NjRuTFxq 1SsO+VooL48dGfQULllq6RpN/2HNvzYAZ1nYyscLqTN2XgQhay9gXAI1M Z24ARZJn/PwEOaSRwhNna8xfcqTbucQUU/8hmWMZ3BhuS0eXL3akS925k pm/CwpgGvv010G1zgETbPeIiAtVjo86nTBKz64h5xQ0bfB3WHD0oD/PfS RqddYHmvRdkYVHnc9iNNlnEbB/SYx7ws/K7w5+QaMm0TCY1PPaRDDnUrD A==; X-CSE-ConnectionGUID: ndNCYhvjTbuOSgEIVnFkiw== X-CSE-MsgGUID: +mz72M5PRRe7iLQCZsA0pg== X-IronPort-AV: E=Sophos;i="6.13,322,1732575600"; d="scan'208";a="42171166" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 28 Feb 2025 11:10:08 +0100 X-CheckPoint: {67C18B80-0-3D6C4912-C3EB4537} X-MAIL-CPID: 5608D6895C0C0D3CBFCC709C8A1F7455_5 X-Control-Analysis: str=0001.0A002109.67C18B7D.005A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 82F04168CC3; Fri, 28 Feb 2025 11:10:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1740737403; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YE6bnB+P2s7EJv1Gtcomzzk1XsCHf5FrUL6+zsepQYk=; b=aSZkHu5tBl4BOPhn0gC5Txm/SbBCY5/5rfv7waBQSlP+aMm8/Um9qsAoVXwaoSUZtOnUyP pDaeTg3ofEWR6FfOgnx0shiC3Ri8BdesYNBINYPB4FBuDBJDJqNdrGM3Cn0wv9YooXlD4u h33CGkpNjaeK9WGLItWAL4Fc3a1e/31YD5cK3B3pONEoqlV/SPN2jFb7uJ76n0xeRS2ubI rgLNhI5OeczxVDpC4uZOSAc372VjNgL9S2XodOeIi/PkxvEOptci76rjnM2LmGada6K0+S SXtWqzD16qzwth9UCSg1zpac/U6Il/LxEV5jXqyyLbP+92xq7XupA80hhp2mmA== From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: Marek Vasut , Boris Brezillon , Conor Dooley , David Airlie , Fabio Estevam , Krzysztof Kozlowski , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Pengutronix Kernel Team , Philipp Zabel , Rob Herring , Sascha Hauer , Sebastian Reichel , Shawn Guo , Simona Vetter , Steven Price , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, Marek Vasut Subject: Re: [PATCH 5/9] drm/panthor: Implement support for multiple power domains Date: Fri, 28 Feb 2025 11:10:02 +0100 Message-ID: <2848587.BEx9A2HvPv@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20250227170012.124768-6-marex@denx.de> References: <20250227170012.124768-1-marex@denx.de> <20250227170012.124768-6-marex@denx.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Am Donnerstag, 27. Februar 2025, 17:58:05 CET schrieb Marek Vasut: > The driver code power domain binding to driver instances only works > for single power domain, in case there are multiple power domains, > it is necessary to explicitly attach via dev_pm_domain_attach*(). > As DT bindings list support for up to 5 power domains, add support > for attaching them all. This is useful on Freescale i.MX95 which > does have two power domains. >=20 > Signed-off-by: Marek Vasut > --- > Cc: Boris Brezillon > Cc: Conor Dooley > Cc: David Airlie > Cc: Fabio Estevam > Cc: Krzysztof Kozlowski > Cc: Liviu Dudau > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Pengutronix Kernel Team > Cc: Philipp Zabel > Cc: Rob Herring > Cc: Sascha Hauer > Cc: Sebastian Reichel > Cc: Shawn Guo > Cc: Simona Vetter > Cc: Steven Price > Cc: Thomas Zimmermann > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: imx@lists.linux.dev > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/gpu/drm/panthor/panthor_device.c | 56 ++++++++++++++++++++++++ > drivers/gpu/drm/panthor/panthor_device.h | 5 +++ > 2 files changed, 61 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panthor/panthor_device.c b/drivers/gpu/drm/p= anthor/panthor_device.c > index 51ee9cae94504..4348b7e917b64 100644 > --- a/drivers/gpu/drm/panthor/panthor_device.c > +++ b/drivers/gpu/drm/panthor/panthor_device.c > @@ -75,6 +75,58 @@ static int panthor_reset_init(struct panthor_device *p= tdev) > return 0; > } > =20 > +/* Generic power domain handling code, see drivers/gpu/drm/tiny/simpledr= m.c */ > +static void panthor_detach_genpd(void *res) > +{ > + struct panthor_device *ptdev =3D res; > + int i; > + > + if (ptdev->pwr_dom_count <=3D 1) > + return; > + > + for (i =3D ptdev->pwr_dom_count - 1; i >=3D 0; i--) > + dev_pm_domain_detach(ptdev->pwr_dom_devs[i], true); > +} > + > +static int panthor_genpd_init(struct panthor_device *ptdev) > +{ > + struct device *dev =3D ptdev->base.dev; > + int i, ret; > + > + ptdev->pwr_dom_count =3D of_count_phandle_with_args(dev->of_node, "powe= r-domains", > + "#power-domain-cells"); > + /* > + * Single power-domain devices are handled by driver core nothing to do > + * here. The same for device nodes without "power-domains" property. > + */ > + if (ptdev->pwr_dom_count <=3D 1) > + return 0; > + > + if (ptdev->pwr_dom_count > ARRAY_SIZE(ptdev->pwr_dom_devs)) { > + drm_warn(&ptdev->base, "Too many power domains (%d) for this device\n", > + ptdev->pwr_dom_count); > + return -EINVAL; > + } > + > + for (i =3D 0; i < ptdev->pwr_dom_count; i++) { > + ptdev->pwr_dom_devs[i] =3D dev_pm_domain_attach_by_id(dev, i); > + if (!IS_ERR(ptdev->pwr_dom_devs[i])) > + continue; > + > + ret =3D PTR_ERR(ptdev->pwr_dom_devs[i]); > + if (ret !=3D -EPROBE_DEFER) { > + drm_warn(&ptdev->base, "pm_domain_attach_by_id(%u) failed: %d\n", i, = ret); > + continue; Is it a good idea to continue if a power-domain is missing? Any access might stuck completely. IMHO returning an error is more sensible. Also some dev_err_probe() should be added here. Best regards Alexander > + } > + > + /* Missing dependency, try again. */ > + panthor_detach_genpd(ptdev); > + return ret; > + } > + > + return devm_add_action_or_reset(dev, panthor_detach_genpd, ptdev); > +} > + > void panthor_device_unplug(struct panthor_device *ptdev) > { > /* This function can be called from two different path: the reset work > @@ -232,6 +284,10 @@ int panthor_device_init(struct panthor_device *ptdev) > if (ret) > return ret; > =20 > + ret =3D panthor_genpd_init(ptdev); > + if (ret) > + return ret; > + > ret =3D panthor_devfreq_init(ptdev); > if (ret) > return ret; > diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/p= anthor/panthor_device.h > index fea3a05778e2e..7fb65447253e9 100644 > --- a/drivers/gpu/drm/panthor/panthor_device.h > +++ b/drivers/gpu/drm/panthor/panthor_device.h > @@ -114,6 +114,11 @@ struct panthor_device { > /** @resets: GPU reset. */ > struct reset_control *resets; > =20 > + /** @pwr_dom_count: Power domain count */ > + int pwr_dom_count; > + /** @pwr_dom_dev: Power domain devices */ > + struct device *pwr_dom_devs[5]; > + > /** @coherent: True if the CPU/GPU are memory coherent. */ > bool coherent; > =20 >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/