Re: [PATCH 8/9] drm/panthor: Add i.MX95 support

Marek Vasut
2025-02-28T18:27:26Z

On 2/28/25 12:23 PM, Florent Tomasin wrote:

Hi,

>>> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
>>> index 06fe46e320738..2504a456d45c4 100644
>>> --- a/drivers/gpu/drm/panthor/panthor_drv.c
>>> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
>>> @@ -1591,6 +1591,7 @@ static struct attribute *panthor_attrs[] = {
>>> ATTRIBUTE_GROUPS(panthor);
>>>
>>> static const struct of_device_id dt_match[] = {
>>> + { .compatible = "fsl,imx95-mali" }, /* G310 */
> No sure the comment about G310 is needed.
>
>>> { .compatible = "rockchip,rk3588-mali" },
>>> { .compatible = "arm,mali-valhall-csf" },
>>> {}
>>> diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c
>>> index 0f07ef7d9aea7..2371ab8e50627 100644
>>> --- a/drivers/gpu/drm/panthor/panthor_gpu.c
>>> +++ b/drivers/gpu/drm/panthor/panthor_gpu.c
>>> @@ -67,6 +67,7 @@ struct panthor_model {
>>> }
>>>
>>> static const struct panthor_model gpu_models[] = {
>>> + GPU_MODEL(g310, 0, 0), /* NXP i.MX95 */
> We can remove the comment about the SoC. This GPU model could be found
> in other vendor platforms.

Maybe it is a good idea to keep track of which GPU is in which SoC at
least this way ?

>> Are you sure about 0, 0? With this I get
>>> [drm] mali-unknown id 0xac74 major 0x0 minor 0x0 status 0x1
>>
>> Using GPU_MODEL(g310, 10, 4) I get:
>>> [drm] mali-g310 id 0xac74 major 0x0 minor 0x0 status 0x1
>
> I'd agree it should be GPU_MODEL(g310, 10, 4). Unless the GPU
> version has been changed by the vendor?
With the fix suggested by Alexander, I get the following output on boot,
so I think 10/4 is OK ?

panthor 4d900000.gpu: [drm] clock rate = 1000000000
panthor 4d900000.gpu: EM: created perf domain
panthor 4d900000.gpu: [drm] mali-g310 id 0xac74 major 0x0 minor 0x0
status 0x1
panthor 4d900000.gpu: [drm] Features: L2:0x7110306 Tiler:0x809 Mem:0x1
MMU:0x2830 AS:0xff
panthor 4d900000.gpu: [drm] shader_present=0x1 l2_present=0x1
tiler_present=0x1
panthor 4d900000.gpu: [drm] Firmware protected mode entry not be
supported, ignoring
panthor 4d900000.gpu: [drm] Firmware git sha:
8e5cfcfec20cc8aff8509d37e72babc935d34a3b
panthor 4d900000.gpu: [drm] CSF FW using interface v1.1.0, Features 0x0
Instrumentation features 0x71
[drm] Initialized panthor 1.3.0 for 4d900000.gpu on minor 0