Re: [PATCH 1/9] dt-bindings: reset: imx95-gpu-blk-ctrl: Document Freescale i.MX95 GPU reset

Marek Vasut
2025-02-27T20:40:21Z

On 2/27/25 6:30 PM, Frank Li wrote:

[...]

>> +examples:
>> + - |
>> + reset-controller@4d810000 {
>> + compatible = "fsl,imx95-gpu-blk-ctrl";
>> + reg = <0x0 0x4d810000 0x0 0xc>;
>
> No sure if it pass dt_binding_check, I remember default 32bit address
> reg = <0x4d810000 0xc>
>
>> + clocks = <&scmi_clk IMX95_CLK_GPUAPB>;
>
> suppose you missed dt-binding include file for IMX95_CLK_GPUAPB
Sigh, I knew I forgot something before sending this series out, thanks.

But we have a bit of a problem here, the IMX95_CLK_GPUAPB macro is
defined in a header in arch/arm64/boot/dts:

arch/arm64/boot/dts/freescale/imx95-clock.h:#define IMX95_CLK_GPUAPB
(IMX95_CCM_NUM_CLK_SRC + 42)

Shouldn't this header be moved into dt-bindings/ ?

I can use fixed number 83 to reference the GPUAPB clock in this binding
document until this is solved, even if that's not a nice thing.