Re: [PATCH v2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On 14/09/2026 09:31, Krzysztof Kozlowski wrote:
> On 14/09/2026 07:56, Quchaosheng wrote:
>> Convert the Freescale MPC5xxx MSCAN controller binding from free-form
>> text to DT schema, and reference the common can-controller.yaml schema.
>>
>> The original text described the two compatible strings and their clock
>> source properties in separate sections. "fsl,mpc5200b-mscan" is added as
>> a fallback of "fsl,mpc5200-mscan", the way existing device trees such as
>> mpc5200b.dtsi use it. The allowed values of fsl,mscan-clock-source are
>> constrained to the strings the driver accepts: the driver compares
>> against "ip", "sys" and "ref" and rejects anything else.
>>
>> The clocks and clock-names properties are documented as well. The driver
> 
> Don't paste here LLM output.
> 
>> looks up the "ipg", "ips", "sys", "ref" and "mclk" clocks by name, and
>> the existing MPC5121 device trees provide exactly those. They were not
>> described by the old text.
> 
> You write complicated paragraphs and complicated sentences in some
> passive voice. Please look at other commits how the commit msg is written.


Also, submitting patches gives some advice, which you used in the first
paragraph but then stopped completely in the rest.

See longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Best regards,
Krzysztof