From: Krzysztof Kozlowski <krzk@kernel.org>
To: Billy Tsai <billy_tsai@aspeedtech.com>,
jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
joel@jms.id.au, andrew@aj.id.au, lee.jones@linaro.org,
thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, BMC-SW@aspeedtech.com,
garnermic@meta.com
Subject: Re: [v3 1/3] dt-bindings: Add bindings for aspeed pwm-tach.
Date: Wed, 2 Nov 2022 17:31:08 -0400 [thread overview]
Message-ID: <2854316e-0874-c8f7-b090-96217dd4a4e5@kernel.org> (raw)
In-Reply-To: <20221102083601.10456-2-billy_tsai@aspeedtech.com>
On 02/11/2022 04:35, Billy Tsai wrote:
> This patch adds device binding for aspeed pwm-tach device which is a
> multi-function device include pwm and tach function and pwm/tach device
> bindings which should be the child-node of pwm-tach device.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> .../bindings/hwmon/aspeed,ast2600-tach.yaml | 48 ++++++++++++
> .../bindings/mfd/aspeed,ast2600-pwm-tach.yaml | 76 +++++++++++++++++++
> .../bindings/pwm/aspeed,ast2600-pwm.yaml | 64 ++++++++++++++++
> 3 files changed, 188 insertions(+)
You sent several versions and still did not Cc me...
My previous feedback applies.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-02 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 8:35 [v3 0/3] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-02 8:35 ` [v3 1/3] dt-bindings: Add bindings for aspeed pwm-tach Billy Tsai
2022-11-02 17:43 ` Rob Herring
2022-11-02 21:31 ` Krzysztof Kozlowski [this message]
2022-11-02 8:36 ` [v3 2/3] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-02 15:56 ` Biju Das
2022-11-07 8:47 ` Billy Tsai
2022-11-07 8:55 ` Biju Das
2022-11-07 9:25 ` Billy Tsai
2022-11-07 9:31 ` Biju Das
2022-11-07 9:38 ` Biju Das
2022-11-02 8:36 ` [v3 3/3] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-02 9:37 ` Christophe JAILLET
2022-11-02 9:42 ` Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2854316e-0874-c8f7-b090-96217dd4a4e5@kernel.org \
--to=krzk@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=garnermic@meta.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).