From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Fabien Parent <fparent@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt8195: add pwm node
Date: Mon, 6 Jun 2022 16:32:16 +0200 [thread overview]
Message-ID: <287b7d3a-a412-0ec9-7be0-c17f3da782b6@collabora.com> (raw)
In-Reply-To: <20220531114544.144785-2-fparent@baylibre.com>
Il 31/05/22 13:45, Fabien Parent ha scritto:
> MT8195's PWM IP has 4 PWM blocks.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
I've verified that the binding is actually right - and it is, the MT8183
data is a perfect match with MT8195.
In any case, there are at least a few MT8195 boards on which the PWM controller
is not used (only the disp-pwm one is used), so please set this node as disabled
by default, after which, you get my:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index d076a376bdcc..366543f27a99 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -367,6 +367,21 @@ pwrap: pwrap@10024000 {
> assigned-clock-parents = <&topckgen CLK_TOP_ULPOSC1_D10>;
> };
>
> + pwm0: pwm@10048000 {
> + compatible = "mediatek,mt8195-pwm",
> + "mediatek,mt8183-pwm";
> + reg = <0 0x10048000 0 0x1000>;
> + #pwm-cells = <2>;
> + clocks = <&infracfg_ao CLK_INFRA_AO_PWM_H>,
> + <&infracfg_ao CLK_INFRA_AO_PWM>,
> + <&infracfg_ao CLK_INFRA_AO_PWM1>,
> + <&infracfg_ao CLK_INFRA_AO_PWM2>,
> + <&infracfg_ao CLK_INFRA_AO_PWM3>,
> + <&infracfg_ao CLK_INFRA_AO_PWM4>;
> + clock-names = "top", "main", "pwm1", "pwm2", "pwm3",
> + "pwm4";
> + };
> +
> scp_adsp: clock-controller@10720000 {
> compatible = "mediatek,mt8195-scp_adsp";
> reg = <0 0x10720000 0 0x1000>;
>
next prev parent reply other threads:[~2022-06-06 14:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 11:45 [PATCH 1/2] dt-bindings: pwm: mediatek: add pwm binding for MT8195 Fabien Parent
2022-05-31 11:45 ` [PATCH 2/2] arm64: dts: mediatek: mt8195: add pwm node Fabien Parent
2022-06-06 14:32 ` AngeloGioacchino Del Regno [this message]
2022-07-01 7:25 ` Uwe Kleine-König
2022-07-01 13:23 ` Uwe Kleine-König
2022-06-05 21:29 ` [PATCH 1/2] dt-bindings: pwm: mediatek: add pwm binding for MT8195 Rob Herring
2022-06-06 14:28 ` AngeloGioacchino Del Regno
2022-07-01 7:22 ` Uwe Kleine-König
2022-07-28 17:15 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=287b7d3a-a412-0ec9-7be0-c17f3da782b6@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=fparent@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).