devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/19] arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs
Date: Sat, 1 Oct 2022 11:12:54 +0200	[thread overview]
Message-ID: <2887c49c-434a-cc1b-b078-1506416e583f@linaro.org> (raw)
In-Reply-To: <20221001030656.29365-3-quic_molvera@quicinc.com>

On 01/10/2022 05:06, Melody Olvera wrote:
> Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000
> SoCs.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile        |  2 ++
>  arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 30 ++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/qru1000-idp.dts | 30 ++++++++++++++++++++++++
>  3 files changed, 62 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts
>  create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 1d86a33de528..398920c530b0 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -152,3 +152,5 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-sony-xperia-sagami-pdx214.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-sony-xperia-sagami-pdx215.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-hdk.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-qrd.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb

List is ordered by name.


> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> new file mode 100644
> index 000000000000..0ecf9a7c41ec
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: BSD-3-Clause-Clear
> +/*
> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "qdu1000.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. QDU1000 IDP";
> +	compatible = "qcom,qdu1000-idp", "qcom,qdu1000";

Undocumented compatibles. You need bindings for these.

> +	qcom,board-id = <0x22 0x0>;
> +
> +	aliases {
> +		serial0 = &uart7;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&qupv3_id_0 {
> +	status = "okay";
> +};
> +
> +&uart7 {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> new file mode 100644
> index 000000000000..ddb4ea17f7d2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts
> @@ -0,0 +1,30 @@
> +// SPDX-License-Identifier: BSD-3-Clause-Clear
> +/*
> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +/dts-v1/;
> +
> +#include "qru1000.dtsi"
> +
> +/ {
> +	model = "Qualcomm Technologies, Inc. QRU1000 IDP";
> +	compatible = "qcom,qru1000-idp", "qcom,qru1000";

Same problem.

> +	qcom,board-id = <0x22 0x0>;

Undocumented compatible. Drop it.

Best regards,
Krzysztof


  parent reply	other threads:[~2022-10-01  9:13 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-01  3:06 [PATCH 00/19] Add base device tree files for QDU1000/QRU1000 Melody Olvera
2022-10-01  3:06 ` [PATCH 01/19] arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs Melody Olvera
2022-10-01  7:22   ` Dmitry Baryshkov
2022-10-11 18:21     ` Melody Olvera
2022-10-01  9:12   ` Krzysztof Kozlowski
2022-10-11 18:22     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 02/19] arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs Melody Olvera
2022-10-01  7:28   ` Dmitry Baryshkov
2022-10-11 18:29     ` Melody Olvera
2022-10-01  9:12   ` Krzysztof Kozlowski [this message]
2022-10-11 18:31     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 03/19] arm64: dts: qcom: qdru1000: Add tlmm nodes Melody Olvera
2022-10-01  7:26   ` Dmitry Baryshkov
2022-10-11 18:40     ` Melody Olvera
2022-10-01  9:14   ` Krzysztof Kozlowski
2022-10-11 18:48     ` Melody Olvera
2022-10-11 18:57       ` Krzysztof Kozlowski
2022-10-11 19:05         ` Melody Olvera
2022-10-11 19:19           ` Krzysztof Kozlowski
2022-10-11 20:01             ` Melody Olvera
2022-10-01  3:06 ` [PATCH 04/19] arm64: dts: qcom: qdu1000: Add reserved memory nodes Melody Olvera
2022-10-01  9:14   ` Krzysztof Kozlowski
2022-10-01  3:06 ` [PATCH 05/19] arm64: dts: qcom: qru1000: " Melody Olvera
2022-10-01  3:06 ` [PATCH 06/19] arm64: dts: qcom: qdru1000: Add smmu nodes Melody Olvera
2022-10-01  7:23   ` Dmitry Baryshkov
2022-10-01  3:06 ` [PATCH 07/19] arm64: dts: qcom: qdu1000-idp: Add RPMH regulators nodes Melody Olvera
2022-10-01  9:15   ` Krzysztof Kozlowski
2022-10-11 21:08     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 08/19] arm64: dts: qcom: qru1000-idp: " Melody Olvera
2022-10-01  9:15   ` Krzysztof Kozlowski
2022-10-11 21:08     ` Melody Olvera
2022-10-01  3:06 ` [PATCH 09/19] arm64: dts: qcom: qdru1000: Add interconnect nodes Melody Olvera
2022-10-01  9:16   ` Krzysztof Kozlowski
2022-10-01  3:06 ` [PATCH 10/19] arm64: dts: qcom: qdru1000: Add rpmhpd node Melody Olvera
2022-10-01  3:06 ` [PATCH 11/19] arm64: dts: qcom: qdru1000: Add spmi node Melody Olvera
2022-10-01  3:06 ` [PATCH 12/19] arm64: dts: qcom: qdu1000-idp: Include pmic file Melody Olvera
2022-10-01  9:16   ` Krzysztof Kozlowski
2022-10-01  3:06 ` [PATCH 13/19] arm64: dts: qcom: qru1000-idp: " Melody Olvera
2022-10-01  3:06 ` [PATCH 14/19] arm64: dts: qcom: qdru1000: Add cpufreq support Melody Olvera
2022-10-01  3:06 ` [PATCH 15/19] arm64: dts: qcom: qdru1000: Add additional QUP nodes Melody Olvera
2022-10-01  3:06 ` [PATCH 16/19] arm64: dts: qcom: qdru1000: Add gpi_dma nodes Melody Olvera
2022-10-01  3:06 ` [PATCH 17/19] arm64: dts: qcom: qdru1000: Add I2C nodes for QUP Melody Olvera
2022-10-01  7:30   ` Dmitry Baryshkov
2022-10-01  3:06 ` [PATCH 18/19] arm64: dts: qcom: qdru1000: Add SPI devices to QUP nodes Melody Olvera
2022-10-01  3:06 ` [PATCH 19/19] arm64: dts: qcom: qdru1000: Add additional UART instances Melody Olvera
2022-10-01  7:32 ` [PATCH 00/19] Add base device tree files for QDU1000/QRU1000 Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2887c49c-434a-cc1b-b078-1506416e583f@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_molvera@quicinc.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).