From: Krzysztof Kozlowski <krzk@kernel.org>
To: Khairul Anuar Romli <khairul.anuar.romli@altera.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM"
<dmaengine@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Niravkumar L Rabara <niravkumar.l.rabara@intel.com>,
"open list:CADENCE NAND DRIVER" <linux-mtd@lists.infradead.org>,
Dinh Nguyen <dinguyen@kernel.org>,
Adrian Ng Ho Yin <adrianhoyin.ng@altera.com>
Subject: Re: [PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property
Date: Mon, 13 Oct 2025 07:41:05 +0200 [thread overview]
Message-ID: <288eff27-ac0c-4e7f-a4cf-cc6169c88f3b@kernel.org> (raw)
In-Reply-To: <60270e2fc2bfb67c0ff4c204e0e8f3395add2146.1760331941.git.khairul.anuar.romli@altera.com>
On 13/10/2025 07:17, Khairul Anuar Romli wrote:
> Agilex5 uses the cdns,hp-nfc binding for the nand-controller node.
That's redundant.
> To support IOMMU functionality, an iommus property needs to be added to the cdns,hp-nfc.yaml binding file.
As well... so just say there is IOMMU used by this <here goes device name>.
> This ensures the device tree binding correctly describes the IOMMU association for the NAND controller.
Redundant. Don't explain us how DT works. We all know. Explain what we
do not know - your hardware. I already ASKED FOR THAT.
Also, completely broken wrapping. Please read submitting patches before
you post next version.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-13 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 5:17 [PATCH v2 0/3] Add iommu supports Khairul Anuar Romli
2025-10-13 5:17 ` [PATCH v2 1/3] dt-bindings: mtd: cdns,hp-nfc: Add iommu property Khairul Anuar Romli
2025-10-13 5:41 ` Krzysztof Kozlowski [this message]
2025-10-13 5:17 ` [PATCH v2 2/3] dt-bindings: dma: snps,dw-axi-dmac: " Khairul Anuar Romli
2025-10-13 5:17 ` [PATCH v2 3/3] arm64: dts: socfpga: agilex5: Add SMMU nodes Khairul Anuar Romli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288eff27-ac0c-4e7f-a4cf-cc6169c88f3b@kernel.org \
--to=krzk@kernel.org \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=adrianhoyin.ng@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=khairul.anuar.romli@altera.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=niravkumar.l.rabara@intel.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).