Re: [PATCH 2/3] ARM: dts: imx6ul: mba6ulx: Fix gpio-keys button node names

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi Shawn,

Am Samstag, 12. August 2023, 03:44:14 CEST schrieb Shawn Guo:
> On Thu, Aug 10, 2023 at 11:55:40AM +0200, Alexander Stein wrote:
> > Numbers are separated by dashes. Fixes the warnings:
> > arch/arm/boot/dts/nxp/imx/imx6ull-tqma6ull2-mba6ulx.dtb: gpio-keys:
> > 'button1', 'button2', 'button3' do not match any of the regexes:
> > '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+
> > -(button|event|key|switch))$', 'pinctrl-[0-9]+'> 
> >  from schema $id: http://devicetree.org/schemas/input/gpio-keys.yaml#
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> 
> It doesn't apply to my imx/dt branch.

Oh, thanks for noticing. A dependent patch was missing and has been included 
in v2.

Thanks and best regards,
Alexander

> Shawn
> 
> > ---
> > 
> >  arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi index 632ceadcca41..5a8b867d7d79
> > 100644
> > --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > @@ -35,21 +35,21 @@ gpio_buttons: gpio-keys {
> > 
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&pinctrl_buttons>;
> > 
> > -		button1 {
> > +		button-1 {
> > 
> >  			label = "s14";
> >  			linux,code = <KEY_1>;
> >  			gpios = <&expander_in0 0 GPIO_ACTIVE_LOW>;
> >  			wakeup-source;
> >  		
> >  		};
> > 
> > -		button2 {
> > +		button-2 {
> > 
> >  			label = "s6";
> >  			linux,code = <KEY_2>;
> >  			gpios = <&expander_in0 1 GPIO_ACTIVE_LOW>;
> >  			wakeup-source;
> >  		
> >  		};
> > 
> > -		button3 {
> > +		button-3 {
> > 
> >  			label = "s7";
> >  			linux,code = <KEY_3>;
> >  			gpios = <&expander_in0 2 GPIO_ACTIVE_LOW>;


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/