From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Ray Chi <raychi@google.com>, Matthias Kaehlcke <mka@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Flavio Suligoi <f.suligoi@asem.it>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY
Date: Thu, 8 Jun 2023 08:01:13 +0000 [thread overview]
Message-ID: <289f65f0554344f69f3b0439a9e706ff@realtek.com> (raw)
In-Reply-To: <7390105c-dad9-2785-1768-7f50b067633a@linaro.org>
> >>
> >> This needs to be specific. What the heck is "PHY parameter"?
> >>
> > It contains more parameters
> > page0 has 16 parameters
> > page1 has 8 parameters
> > page2 has 8 parameters
> > It's tedious if we list them all.
>
> Sure, if you prefer not to list them, then they should be removed from DT.
>
> > And we only set the part that differs from the default.
> > It's hard to explain which parameters were changed because each platform is
> different.
>
> If this is phy tuning per board, you need to explain and justify them.
> If this is per platform, then drop it - not even needed, because you have
> compatible for this.
>
Okay, I try to specify by the compatible.
Thanks,
Stanley
next prev parent reply other threads:[~2023-06-08 8:02 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 6:24 [PATCH v3 1/5] usb: phy: add usb phy notify port status API Stanley Chang
2023-06-07 6:24 ` [PATCH v3 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 11:26 ` kernel test robot
2023-06-07 11:54 ` Krzysztof Kozlowski
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:00 ` Krzysztof Kozlowski
2023-06-08 7:15 ` Krzysztof Kozlowski
2023-06-07 17:31 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-08 6:55 ` Krzysztof Kozlowski
2023-06-08 7:07 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 3/5] phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 11:52 ` Krzysztof Kozlowski
2023-06-08 6:59 ` Stanley Chang[昌育德]
2023-06-08 7:21 ` Krzysztof Kozlowski
2023-06-08 7:40 ` Stanley Chang[昌育德]
2023-06-08 1:35 ` kernel test robot
2023-06-08 2:18 ` Stanley Chang[昌育德]
2023-06-07 6:24 ` [PATCH v3 4/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 2.0 PHY Stanley Chang
2023-06-07 12:04 ` Krzysztof Kozlowski
2023-06-08 7:24 ` Stanley Chang[昌育德]
2023-06-08 7:49 ` Krzysztof Kozlowski
2023-06-08 8:21 ` Stanley Chang[昌育德]
2023-06-08 8:28 ` Krzysztof Kozlowski
2023-06-08 9:27 ` Stanley Chang[昌育德]
2023-06-08 7:47 ` Stanley Chang[昌育德]
2023-06-08 7:51 ` Krzysztof Kozlowski
2023-06-08 8:01 ` Stanley Chang[昌育德] [this message]
2023-06-07 6:24 ` [PATCH v3 5/5] dt-bindings: phy: realtek: Add the doc about the Realtek SoC USB 3.0 PHY Stanley Chang
2023-06-07 12:08 ` Krzysztof Kozlowski
2023-06-08 7:32 ` Stanley Chang[昌育德]
2023-06-08 7:50 ` Krzysztof Kozlowski
2023-06-08 8:00 ` Stanley Chang[昌育德]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289f65f0554344f69f3b0439a9e706ff@realtek.com \
--to=stanley_chang@realtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).