From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B78122550C8 for ; Tue, 20 May 2025 10:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747738282; cv=none; b=r95t9InyhK9Z34uIUiFQPx2R/9wwiPa7furC/bl/mn76VQTJgHv/Kky1RCK5Jb0QMmPP0PVeqNbiFZvOnY9TlSGenIXpMru+SmV/k3sRgC+NgTDzZ+Jz/YuJzD4eUj1sru6HKypDAhZR1oHXkMVqAlh3e3KZpcvvy0IHHJHPVD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747738282; c=relaxed/simple; bh=1IVxMRT7hTE5gir+ohubrLWQS9DrJZsBgibqpQP6RLI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eBjJVu0gVKdPp1Aq1frX59FeUV7axlFdQJc1rYEcbj5xsDcDCaAPIficjJ9knjK65tkG2Tuqc7x8ceDvRv7Tb1WwC4uEcCODLELQtXi7wI9qgS1szwvY7B8EfNUl2LiX6AUxwkCTkk/YNSAZFqyaptYrdnmtLprHP9jtnbA/rlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=UxoPjZoU; arc=none smtp.client-ip=121.127.44.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="UxoPjZoU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1747738273; bh=IjZMD2eULGDwifJ6Eg5o2azP2kaC3eB2jYmU3yHnbXU=; b=UxoPjZoUJrc45g5sIvR0ZUH26COyeTPktfRjT7bkP0nsiiK+GAah3KYfa+ObaHEYCRArJmNKe C301BfOUXchYK4BaYifBE97R4VHMXr8jQJ7QO6/SxmXhxOixCspcylmUpVoYb5X8tU2J+S+RTNj sNWkgXayr+AsqjAAbHYhsIaScmsECJz6TKLoXFRE+hiFzWAGe41dmJGpDRPapp63Mv9h7txNkPr PXeleTsn/+1FXyivTPb5jYHVqkV4s5/JroK4HvJnB8+SEa/qsqWL/0W1/HoGHQAXIytvBo/CIur QIsv0hwXlXJrM/lYxuu5nRsztixkpBI6vpEPXN78j8OA== X-Forward-Email-ID: 682c5e9c356c24cb84e6ffc4 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.73 X-Forward-Email-Version: 1.0.3 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: <28b03818-0290-412a-8d1e-9b88a163d387@kwiboo.se> Date: Tue, 20 May 2025 12:51:03 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add spi nodes for RK3528 To: Chukun Pan , Heiko Stuebner Cc: Yao Zi , Rob Herring , Mark Brown , Conor Dooley , Krzysztof Kozlowski , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-spi@vger.kernel.org" References: <20250520100102.1226725-1-amadeus@jmu.edu.cn> <20250520100102.1226725-3-amadeus@jmu.edu.cn> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20250520100102.1226725-3-amadeus@jmu.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2025-05-20 12:01, Chukun Pan wrote: > There are 2 SPI controllers on the RK3528 SoC, describe it. > > Signed-off-by: Chukun Pan > --- > arch/arm64/boot/dts/rockchip/rk3528.dtsi | 28 ++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3528.dtsi b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > index b2724c969a76..4d60c09219f9 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3528.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3528.dtsi > @@ -371,6 +371,34 @@ ioc_grf: syscon@ff540000 { > reg = <0x0 0xff540000 0x0 0x40000>; > }; > > + spi0: spi@ff9c0000 { > + compatible = "rockchip,rk3528-spi", > + "rockchip,rk3066-spi"; > + reg = <0x0 0xff9c0000 0x0 0x1000>; > + clocks = <&cru CLK_SPI0>, <&cru PCLK_SPI0>; > + clock-names = "spiclk", "apb_pclk"; > + interrupts = ; > + dmas = <&dmac 25>, <&dmac 24>; > + dma-names = "tx", "rx"; This is missing power-domains after "rockchip: Add power controller support for RK3528" [1], spi0 depend on pclk_rkvenc_root: power-domains = <&power RK3528_PD_RKVENC>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + spi1: spi@ff9d0000 { > + compatible = "rockchip,rk3528-spi", > + "rockchip,rk3066-spi"; > + reg = <0x0 0xff9d0000 0x0 0x1000>; > + clocks = <&cru CLK_SPI1>, <&cru PCLK_SPI1>; > + clock-names = "spiclk", "apb_pclk"; > + interrupts = ; > + dmas = <&dmac 31>, <&dmac 30>; > + dma-names = "tx", "rx"; Same here, spi1 depend on pclk_vpu_root: power-domains = <&power RK3528_PD_VPU>; [1] https://lore.kernel.org/r/20250518220707.669515-1-jonas@kwiboo.se Regards, Jonas > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > uart0: serial@ff9f0000 { > compatible = "rockchip,rk3528-uart", "snps,dw-apb-uart"; > reg = <0x0 0xff9f0000 0x0 0x100>;