From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Heng Sia <jee.heng.sia@intel.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset
Date: Fri, 26 Nov 2021 09:01:28 +0900 [thread overview]
Message-ID: <28be175a-8e9b-937a-de35-bcc218006fe9@opensource.wdc.com> (raw)
In-Reply-To: <20211125152008.162571-1-geert@linux-m68k.org>
On 2021/11/26 0:20, Geert Uytterhoeven wrote:
> "make dtbs_check":
>
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> arch/riscv/boot/dts/canaan/sipeed_maix_bit.dt.yaml: dma-controller@50000000: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
>
> The Synopsys DesignWare AXI DMA Controller on the Canaan K210 SoC
> exposes its reset signal.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 90d9274e5464e396..06ddffaada295171 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -53,6 +53,9 @@ properties:
> minimum: 1
> maximum: 8
>
> + resets:
> + maxItems: 1
> +
> snps,dma-masters:
> description: |
> Number of AXI masters supported by the hardware.
>
Looks good to me.
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-11-26 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 15:20 [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Document optional reset Geert Uytterhoeven
2021-11-26 0:01 ` Damien Le Moal [this message]
2021-12-01 22:44 ` Rob Herring
2021-12-13 6:25 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28be175a-8e9b-937a-de35-bcc218006fe9@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jee.heng.sia@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).