Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	"Konrad Dybcio" <konradybcio@kernel.org>,
	"Stephan Gerhold" <stephan@gerhold.net>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 3/7] remoteproc: qcom_q6v5_mss: Use mss as regulator for MSM8953
Date: Tue, 30 Jun 2026 15:01:45 +0200	[thread overview]
Message-ID: <28bf1937-55d6-4ca5-a572-3bc7d0958608@oss.qualcomm.com> (raw)
In-Reply-To: <C5AF7872-093B-4039-9F3A-72BF855BB3D1@mainlining.org>

On 6/4/26 2:33 PM, Barnabás Czémán wrote:
> 
> 
> On 16 April 2026 15:32:25 CEST, Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> wrote:
>> On 3/27/26 9:11 PM, Barnabás Czémán wrote:
>>> MSM8953 MSS is using mss-supply as regulator what is usually pm8953_s1.
>>>
>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>>> ---
>>>  drivers/remoteproc/qcom_q6v5_mss.c | 9 ++++++++-
>>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
>>> index 4e9eb5bd11fa..86edd826ede8 100644
>>> --- a/drivers/remoteproc/qcom_q6v5_mss.c
>>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
>>> @@ -2705,6 +2705,14 @@ static const struct rproc_hexagon_res msm8953_mss = {
>>>  		},
>>>  		{}
>>>  	},
>>> +	.active_supply = (struct qcom_mss_reg_res[]) {
>>> +		{
>>> +			.supply = "mss",
>>> +			.uV = 1050000,
>>> +			.uA = 100000,
>>
>> I don't know if it's a typo, but msm8953-regulator.dtsi on msm-3.18
>> suggests one more zero
> I do not see any load values there only init-voltage what have six zeros.

Yes, you're right

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

  reply	other threads:[~2026-06-30 13:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 20:11 [PATCH 0/7] MSM8953/SDM632 rpmpd/mss fixes Barnabás Czémán
2026-03-27 20:11 ` [PATCH 1/7] dt-bindings: power: qcom-rpmpd: Split MSM8953 and SDM632 Barnabás Czémán
2026-03-27 20:26   ` Dmitry Baryshkov
2026-03-28  8:22     ` Barnabás Czémán
2026-03-29  9:51       ` Dmitry Baryshkov
2026-03-30  9:24       ` Konrad Dybcio
2026-03-29  9:37   ` Krzysztof Kozlowski
2026-03-27 20:11 ` [PATCH 2/7] pmdomain: qcom: rpmpd: Split SDM632 pm domains from MSM8953 Barnabás Czémán
2026-03-27 20:11 ` [PATCH 3/7] remoteproc: qcom_q6v5_mss: Use mss as regulator for MSM8953 Barnabás Czémán
2026-04-16 13:32   ` Konrad Dybcio
2026-06-04 12:33     ` Barnabás Czémán
2026-06-30 13:01       ` Konrad Dybcio [this message]
2026-03-27 20:11 ` [PATCH 4/7] arm64: dts: qcom: msm8953: fix modem pm domains Barnabás Czémán
2026-03-27 20:35   ` Dmitry Baryshkov
2026-04-16 13:33     ` Konrad Dybcio
2026-03-27 20:11 ` [PATCH 5/7] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add SDM632 Barnabás Czémán
2026-03-27 20:11 ` [PATCH 6/7] remoteproc: qcom_q6v5_mss: Add SDM632 MSS Barnabás Czémán
2026-04-16 13:32   ` Konrad Dybcio
2026-03-27 20:11 ` [PATCH 7/7] arm64: dts: qcom: sdm632: Correct power domains Barnabás Czémán
2026-04-16 13:34   ` Konrad Dybcio
2026-03-27 20:33 ` [PATCH 0/7] MSM8953/SDM632 rpmpd/mss fixes Dmitry Baryshkov
2026-03-27 20:38   ` Barnabás Czémán
2026-03-27 20:45     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28bf1937-55d6-4ca5-a572-3bc7d0958608@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=stephan@gerhold.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox