From: Sricharan R <sricharan@codeaurora.org>
To: Abhishek Sahu <absahu@codeaurora.org>
Cc: robh+dt@kernel.org, robh@kernel.org, mark.rutland@arm.com,
linux@armlinux.org.uk, andy.gross@linaro.org,
david.brown@linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, sboyd@codeaurora.org,
bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org
Subject: Re: [PATCH v2 12/13] ARM: dts: ipq8074: Add pcie nodes
Date: Fri, 16 Mar 2018 18:12:18 +0530 [thread overview]
Message-ID: <28faf397-5d28-0ec2-15b1-2a39b2eb426f@codeaurora.org> (raw)
In-Reply-To: <69ff9b14b9b2fe4d90a02ca629059af2@codeaurora.org>
Hi Abhishek,
On 3/16/2018 4:50 PM, Abhishek Sahu wrote:
> On 2018-03-16 15:08, Sricharan R wrote:
>> The driver/phy support for ipq8074 is available now.
>> So enabling the nodes in DT.
>>
>> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/ipq8074.dtsi | 157 +++++++++++++++++++++++++++++++++-
>> 1 file changed, 156 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> index 806fc56..7562650 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
>> @@ -24,7 +24,7 @@
>> ranges = <0 0 0 0xffffffff>;
>> compatible = "simple-bus";
>>
>> - pinctrl@1000000 {
>> + tlmm: pinctrl@1000000 {
>> compatible = "qcom,ipq8074-pinctrl";
>> reg = <0x1000000 0x300000>;
>> interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>;
>> @@ -229,6 +229,161 @@
>> dma-names = "tx", "rx", "cmd";
>> status = "disabled";
>> };
>> +
>> + pcie_phy0: phy@86000 {
>> + compatible = "qcom,ipq8074-qmp-pcie-phy";
>> + reg = <0x86000 0x1000>;
>> + #phy-cells = <0>;
>> + clocks = <&gcc GCC_PCIE0_PIPE_CLK>;
>> + clock-names = "pipe_clk";
>> + clock-output-names = "pcie20_phy0_pipe_clk";
>> +
>> + resets = <&gcc GCC_PCIE0_PHY_BCR>,
>> + <&gcc GCC_PCIE0PHY_PHY_BCR>;
>> + reset-names = "phy",
>> + "common";
>> + status = "disabled";
>> + };
>> +
>> + pcie0: pci@20000000 {
>> + compatible = "qcom,pcie-ipq8074";
>> + reg = <0x20000000 0xf1d
>> + 0x20000F20 0xa8
>
> s/0x20000F20/0x20000f20
ok
>
>> + 0x80000 0x2000
>> + 0x20100000 0x1000>;
>> + reg-names = "dbi", "elbi", "parf", "config";
>> + device_type = "pci";
>> + linux,pci-domain = <0>;
>> + bus-range = <0x00 0xff>;
>> + num-lanes = <1>;
>> + #address-cells = <3>;
>> + #size-cells = <2>;
>> +
>> + phys = <&pcie_phy0>;
>> + phy-names = "pciephy";
>> +
>> + ranges = <0x81000000 0 0x20200000 0x20200000
>> + 0 0x00100000 /* downstream I/O */
>
> we can remove trailing zeros from address.
> s/0x00100000/0x100000
>
>> + 0x82000000 0 0x20300000 0x20300000
>> + 0 0x00d00000>; /* non-prefetchable memory */
>
> s/0x00d00000/0xd00000
>
> Same changes are for PCIE1 also.
ok
>
> With that.
>
> Reviewed-by: Abhishek Sahu <absahu@codeaurora.org>
Thanks.
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2018-03-16 12:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 9:38 [PATCH v2 00/13] ARM: dts: ipq: updates to enable a few peripherals Sricharan R
2018-03-16 9:38 ` [PATCH v2 01/13] firmware: qcom: scm: Add ipq4019 soc compatible Sricharan R
2018-03-16 9:38 ` [PATCH v2 02/13] ARM: dts: ipq4019: Add a few peripheral nodes Sricharan R
2018-03-16 10:17 ` Abhishek Sahu
2018-03-16 11:29 ` Abhishek Sahu
2018-03-16 12:17 ` Marc Zyngier
2018-03-16 12:40 ` Sricharan R
2018-03-16 9:38 ` [PATCH v2 03/13] ARM: dts: ipq4019: Change the max opp frequency Sricharan R
2018-03-16 10:19 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 04/13] ARM: dts: ipq4019: Update ipq4019-dk01.1 board data Sricharan R
2018-03-16 10:20 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 05/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.dtsi Sricharan R
2018-03-16 10:21 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 06/13] ARM: dts: ipq4019: Add ipq4019-ap.dk04.1-c1 board file Sricharan R
2018-03-16 10:21 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 07/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk04.1-c3 " Sricharan R
2018-03-16 10:22 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 08/13] ARM: dts: ipq4019: Add ipq4019-ap.dk07.1 common data Sricharan R
2018-03-16 10:22 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 09/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c1 board file Sricharan R
2018-03-16 10:25 ` Abhishek Sahu
2018-03-16 12:45 ` Sricharan R
2018-03-16 9:38 ` [PATCH v2 10/13] ARM: dts: ipq4019: Add qcom-ipq4019-ap.dk07.1-c2 " Sricharan R
2018-03-16 10:27 ` Abhishek Sahu
2018-03-16 9:38 ` [PATCH v2 11/13] ARM: dts: ipq8074: Add peripheral nodes Sricharan R
2018-03-16 10:47 ` Abhishek Sahu
2018-03-16 12:43 ` Sricharan R
2018-03-16 9:38 ` [PATCH v2 12/13] ARM: dts: ipq8074: Add pcie nodes Sricharan R
2018-03-16 11:20 ` Abhishek Sahu
2018-03-16 12:42 ` Sricharan R [this message]
2018-03-16 9:38 ` [PATCH v2 13/13] ARM: dts: ipq8074: Enable few peripherals for hk01 board Sricharan R
2018-03-16 10:57 ` Abhishek Sahu
2018-03-16 12:43 ` Sricharan R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28faf397-5d28-0ec2-15b1-2a39b2eb426f@codeaurora.org \
--to=sricharan@codeaurora.org \
--cc=absahu@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).