From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Matt Ranostay <mranostay@ti.com>,
peda@axentia.se, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, vigneshr@ti.com
Cc: devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: ti-serdes-mux: Add defines for J784S4 SoC
Date: Sat, 15 Oct 2022 09:08:21 -0400 [thread overview]
Message-ID: <28fe43a1-426d-e08e-35af-a315197acfba@linaro.org> (raw)
In-Reply-To: <20221015055024.191855-1-mranostay@ti.com>
On 15/10/2022 01:50, Matt Ranostay wrote:
> There are 4 lanes in the single instance of J784S4 SERDES. Each SERDES
> lane mux can select up to 4 different IPs. Define all the possible
> functions.
>
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
> include/dt-bindings/mux/ti-serdes.h | 62 +++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> Related patchset series for j784s4 support:
> Link: https://lore.kernel.org/linux-arm-kernel/20221014082314.118361-1-a-nandan@ti.com/
>
> diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
> index d3116c52ab72..669ca2d6abce 100644
> --- a/include/dt-bindings/mux/ti-serdes.h
> +++ b/include/dt-bindings/mux/ti-serdes.h
> @@ -117,4 +117,66 @@
> #define J721S2_SERDES0_LANE3_USB 0x2
> #define J721S2_SERDES0_LANE3_IP4_UNUSED 0x3
>
> +/* J784S4 */
> +
> +#define J784S4_SERDES0_LANE0_IP1_UNUSED 0x0
You shouldn't store register values in the bindings. It's not their
purpose and there is no single need.
Although pattern already started here, so that's not a problem of this
patch:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-10-15 13:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 5:50 [PATCH] dt-bindings: ti-serdes-mux: Add defines for J784S4 SoC Matt Ranostay
2022-10-15 13:08 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28fe43a1-426d-e08e-35af-a315197acfba@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=mranostay@ti.com \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).