From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Date: Fri, 01 Jul 2016 11:46:04 +0200 Message-ID: <29091648.CIZSyGWL7u@wuerfel> References: <1467327554-22074-1-git-send-email-jon.mason@broadcom.com> <1467327554-22074-7-git-send-email-jon.mason@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1467327554-22074-7-git-send-email-jon.mason@broadcom.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jon Mason Cc: Mark Rutland , devicetree@vger.kernel.org, f.fainelli@gmail.com, Scott Branden , Pawel Moll , Ian Campbell , hauke@hauke-m.de, zajec5@gmail.com, linux-kernel@vger.kernel.org, Ray Jui , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Kumar Gala , netdev@vger.kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote: > + > +Required properties: > + - compatible: "brcm,bgmac-nsp" > + - reg: Address and length of the GMAC registers, > + Address and length of the GMAC IDM registers > + - reg-names: Names of the registers. Must have both "gmac_base" and > + "idm_base" > + - interrupts: Interrupt number > + "brcm,bgmac-nsp" sounds a bit too general. As I understand, this is a family of SoCs that might not all have the exact same implementation of this ethernet device, as we can see from the long lookup table in bgmac_probe(). Please document the specific product numbers here that are publically known already. Having the driver match just on "brcm,bgmac-nsp" as a fallback is fine, so you can document that one as required for all users. Arnd