From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2746017551 for ; Fri, 8 Mar 2024 13:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709903070; cv=none; b=ImkDWYFI5UON2s9ehClypxHomMsBrFWJQHZ2RzSb6NkEgDCLHLCTaTxWYH+m8sr3gzOlS9IhTHo2PG4sLcvowWi0/I8AvrePoy2Fg50juvnreUEznn8+SzaOhq9vBjt1DtQdBRohz977aCL51mtgMGItGZpPWXBhI5GGtmv+bAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709903070; c=relaxed/simple; bh=yRWdVfpQxqHtySeHiXZsB0Tjfqjdc3FOYFaeh5FUKVI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TxFsjC/HMZ6NaG8niAdfFMLO7xEiR8PxcAxVdVxsjmmFFuqKW20af3F66ZJPAFhMrpbQQn9DqJmL6mFTs34cMd/yx8AOTY6+XyBfjPjMz7BKfagws2YT4+Nr8PUCqdVcrkMiSaNuUBdUGPkXiBODb+wTVqOq6boGgemOxGleZWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Web9H/sb; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Web9H/sb" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-33e7ae72312so95930f8f.1 for ; Fri, 08 Mar 2024 05:04:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709903067; x=1710507867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QQ57E0ArmK/bVUfP0mzi0MhsZFrvk857kv7W7dfFr2Y=; b=Web9H/sbGFVzPeK2q4KjbOJ3YpE5RP1lRrxdMX1V5YQSrhYZpypHYccoZ/5PwoTacg o2kHRszVATHZckNnJLMPCRMvK+9xhIWOh0BYaSzAH/gibpKbNYzsmQTaYM9kFvPW8yVn zjtNOqKb5uv+ynLTEuJJHZ+4C02qAq1GTFQ2QIt5JryBRQAP6yXMp3eXrVcv5FMIZyy4 b1SS7+uKp1A79SPzC7V6Kpthy3nWyOI8qy5J8onb/HXS8/D1kb8SG1X2gwJbA0rTrhvI xpI2KpK6FhYosMP5Yx1NW8Ou34Bkp8G3yEpquKoIkiQE1JCSIP7sR4yY1yWVBvFIjKsN cFuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709903067; x=1710507867; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QQ57E0ArmK/bVUfP0mzi0MhsZFrvk857kv7W7dfFr2Y=; b=N9y7E1qEWMvgXfuBv5JeR5pVAFj7ZSxUPd2/F9Ue7MMjljNGJ0I4mfPhBpdeK4aE7H vGQ4rA1Y06e7EjLsjOnA1ulcYpFQs2ANAe4vteoaaR4/qcE4un4vY+XNXHcnda2HhAKQ opqUmN5JiISsbWSw0vL8oEDwBoJ7tQ9x3JI/UU9Wfaooog14N+A1XlZsmOm3dp+X8waG Bpf4BWYbFFmsWMbYhl5vziJCeVaQxuuK7QuthDMWAPLj2dq9dmq31mw/nClKGgW1mZtd SuUPAt+W6wXvdwYeU8A9EbrBTxFhZBuvWKDiXvKFNxFhy4ZtMdbdrujWxd3emgxdSYWy P/Lg== X-Forwarded-Encrypted: i=1; AJvYcCU9kbVBqhPnBNsTl73wnofG8whxhuoQo00gguGq9dICaTn4iDVwQEADshqxyKQrQWg256WoIB8vx/B0leFA/wAbUBBH8CIO/nQNEQ== X-Gm-Message-State: AOJu0Yw6ZqKTuc57oQXIVoLx8gIMY3ztfrMFuo6FGghOT8DYgre5LYMZ /bmOdjTD//ZJDxiNz1XXbgUZ/zebCESGU3PqjisClzSU6mAABemlt+hzKmvfX2A= X-Google-Smtp-Source: AGHT+IHCkwidEwgVLTE4ZqN7hKFvS6AkaL79HDNSUljGLcAHE0kLzs+LBju0bJVMOYhQqVw7bXiGkA== X-Received: by 2002:a05:6000:180c:b0:33d:be6f:7dcf with SMTP id m12-20020a056000180c00b0033dbe6f7dcfmr14295647wrh.24.1709903067129; Fri, 08 Mar 2024 05:04:27 -0800 (PST) Received: from [192.168.0.102] ([176.61.106.68]) by smtp.gmail.com with ESMTPSA id f10-20020a5d58ea000000b0033d4cf751b2sm22772090wrd.33.2024.03.08.05.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 05:04:26 -0800 (PST) Message-ID: <291279e1-7abb-4614-91f3-af9ede349817@linaro.org> Date: Fri, 8 Mar 2024 13:04:25 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/5] clk: qcom: Add camera clock controller driver for SM8150 Content-Language: en-US To: "Satya Priya Kakitapalli (Temp)" , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona References: <20240229-camcc-support-sm8150-v1-0-8c28c6c87990@quicinc.com> <20240229-camcc-support-sm8150-v1-4-8c28c6c87990@quicinc.com> <18567989-fb60-49ae-92e6-94e1bc2fa1c7@linaro.org> <83fd1995-a06e-b76a-d91b-de1c1a6ab0ea@quicinc.com> <4817a5b0-5407-4437-b94a-fc8a1bfcd25d@linaro.org> <35a7ad40-aaf4-476e-8582-b83bac284881@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/03/2024 12:40, Satya Priya Kakitapalli (Temp) wrote: > > If BIT(0) is set from probe, during any active usecase, the clock gets > turned ON automatically when the power domain is turned ON. Sounds like a very dirty hack really doesn't it. Can you point out where ? > But when we use CLK_IS_CRITICAL flag, the framework keeps the power > domain ON and doesn't let the power domain to turn off even when there > is no active usecase. --- bod