From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca@z3ntu.xyz>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Julian Goldsmith <julian@juliangoldsmith.com>,
Oleg Chernovskiy <kanedias@keemail.me>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add OnePlus One
Date: Sun, 27 Nov 2022 22:08:25 +0100 [thread overview]
Message-ID: <292eca02-e59a-88af-8823-f14440ffe592@linaro.org> (raw)
In-Reply-To: <20221127181835.806410-2-luca@z3ntu.xyz>
On 27/11/2022 19:18, Luca Weiss wrote:
> From: Julian Goldsmith <julian@juliangoldsmith.com>
>
> OnePlus One is a smartphone launched in 2014 and is based on the
> Snapdragon 801 SoC (-AC variant).
>
Thank you for your patch. There is something to discuss/improve.
> +
> +&blsp1_uart2 {
> + status = "okay";
> +};
> +
> +&gcc {
> + compatible = "qcom,gcc-msm8974pro-ac";
> +};
> +
> +&otg {
> + phys = <&usb_hs1_phy>;
> + phy-select = <&tcsr 0xb000 0>;
> + extcon = <&smbb>, <&usb_id>;
> + vbus-supply = <&chg_otg>;
> +
> + hnp-disable;
> + srp-disable;
> + adp-disable;
> +
> + status = "okay";
> +
> + ulpi {
> + phy@a {
> + status = "okay";
Override by label (usb_hs1_phy). If the labels are named similarly, e.g.
usb_oth and usb_hs1_phy, then they will appear next to each other during
override/extend.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-27 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 18:18 [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device Luca Weiss
2022-11-27 18:18 ` [PATCH 2/2] ARM: dts: qcom: msm8974: Add OnePlus One Luca Weiss
2022-11-27 21:08 ` Krzysztof Kozlowski [this message]
2022-11-27 21:05 ` [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device Krzysztof Kozlowski
2022-11-27 21:25 ` Dmitry Baryshkov
2022-11-27 21:30 ` Krzysztof Kozlowski
2022-11-27 21:43 ` Dmitry Baryshkov
2022-11-28 8:34 ` Krzysztof Kozlowski
2022-11-28 12:44 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292eca02-e59a-88af-8823-f14440ffe592@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=julian@juliangoldsmith.com \
--cc=kanedias@keemail.me \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=olof@lixom.net \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).