From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Rob Herring <robh+dt@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 1/7] dt-bindings: ufs: Document Rockchip UFS host controller
Date: Fri, 8 Nov 2024 12:57:41 +0100 [thread overview]
Message-ID: <292f6e8a-b892-4645-a7e7-6279b6d343a8@kernel.org> (raw)
In-Reply-To: <bpxlah7lewfhbpe6555d6pb6sfj6eziu2ski5iiazu7pwpwc5j@jrhvjyke5rzl>
On 08/11/2024 12:57, Krzysztof Kozlowski wrote:
> On Fri, Nov 08, 2024 at 02:56:20PM +0800, Shawn Lin wrote:
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>> + - clocks
>> + - clock-names
>> + - interrupts
>> + - power-domains
>> + - resets
>> + - reset-names
>> + - reset-gpios
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/rockchip,rk3576-cru.h>
>> + #include <dt-bindings/reset/rockchip,rk3576-cru.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + #include <dt-bindings/power/rockchip,rk3576-power.h>
>> + #include <dt-bindings/pinctrl/rockchip.h>
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + soc {
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> +
>> + ufshc: ufshc@2a2d0000 {
>> + compatible = "rockchip,rk3576-ufshc";
>
> Odd alignment.
I meant, indentation. Should be 4 spaces but is 6? or 8?
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-08 11:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 6:56 [PATCH v5 0/7] Initial support for RK3576 UFS controller Shawn Lin
2024-11-08 6:56 ` [PATCH v5 1/7] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2024-11-08 11:57 ` Krzysztof Kozlowski
2024-11-08 11:57 ` Krzysztof Kozlowski [this message]
2024-11-08 6:56 ` [PATCH v5 2/7] soc: rockchip: add header for suspend mode SIP interface Shawn Lin
2024-11-08 6:56 ` [PATCH v5 3/7] pmdomain: core: Introduce dev_pm_genpd_rpm_always_on() Shawn Lin
2024-11-12 14:36 ` Ulf Hansson
2024-11-08 6:56 ` [PATCH v5 4/7] pmdomain: rockchip: Add smc call to inform firmware Shawn Lin
2024-11-08 6:56 ` [PATCH v5 5/7] scsi: ufs: core: Export ufshcd_dme_reset() and ufshcd_dme_enable() Shawn Lin
2024-11-23 5:02 ` Manivannan Sadhasivam
2024-11-08 6:56 ` [PATCH v5 6/7] scsi: ufs: rockchip: initial support for UFS Shawn Lin
2024-11-12 14:54 ` Ulf Hansson
2024-11-23 5:01 ` Manivannan Sadhasivam
2024-11-25 3:41 ` Shawn Lin
2024-11-08 6:56 ` [PATCH v5 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC Shawn Lin
2024-11-23 5:04 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292f6e8a-b892-4645-a7e7-6279b6d343a8@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cl@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=zyf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox