Re: [PATCH v2 1/4] phy: phy-stih407-usb: Add usb picoPHY driver found on stih407 SoC family

Peter Griffin
2014-09-09T10:26:55Z

Hi Arnd,

Thanks for reviewing :-)

> > + phy = devm_phy_create(dev, NULL, match->data, NULL);
> > + if (IS_ERR(phy)) {
> > + dev_err(dev, "failed to create Display Port PHY\n");
> > + return PTR_ERR(phy);
> > + }
> > +
>
> There is only one entry in the match table, so it always points to
> stih407_usb2_picophy_data. Do you have plans to add another set of
> operations soon?

Nope.

> If not, just remove the .data pointer and hardcode the operations
> in the devm_phy_create call.

I've done as you suggest in v3 which I will send shortly.

regards,

Peter.