From: Krzysztof Kozlowski <krzk@kernel.org>
To: Crystal Guo <crystal.guo@mediatek.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface
Date: Sun, 9 Feb 2025 11:51:27 +0100 [thread overview]
Message-ID: <2942fbc2-55c5-4789-89d4-e4bf3158a34b@kernel.org> (raw)
In-Reply-To: <20250207014437.17920-3-crystal.guo@mediatek.com>
On 07/02/2025 02:42, Crystal Guo wrote:
> A MediaTek DRAM controller interface to provide the current DDR data rate.
>
Duplicated patch.
You also ignored several comments so that's a NAK.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-09 10:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 1:42 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-07 1:42 ` [v2,1/2] memory/mediatek: " Crystal Guo
2025-02-09 10:50 ` Krzysztof Kozlowski
2025-02-11 11:33 ` Crystal Guo (郭晶)
2025-03-04 14:59 ` AngeloGioacchino Del Regno
2025-03-17 2:30 ` Crystal Guo (郭晶)
2025-02-07 1:42 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:51 ` Krzysztof Kozlowski [this message]
2025-02-12 3:50 ` Crystal Guo (郭晶)
2025-02-12 5:34 ` Krzysztof Kozlowski
2025-02-12 10:07 ` Crystal Guo (郭晶)
-- strict thread matches above, loose matches on Subject: below --
2025-02-06 12:16 [v2,0/2] Add an interface to get current DDR data rate Crystal Guo
2025-02-06 12:16 ` [v2,2/2] dt-bindings: memory-controllers: Add MediaTek DRAM controller interface Crystal Guo
2025-02-09 10:48 ` Krzysztof Kozlowski
2025-02-11 11:25 ` Crystal Guo (郭晶)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2942fbc2-55c5-4789-89d4-e4bf3158a34b@kernel.org \
--to=krzk@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=crystal.guo@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).