From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3] clocksource: arch_timer: Allow the device tree to specify uninitialized CNTVOFF Date: Tue, 07 Oct 2014 09:40:57 +0200 Message-ID: <2943095.1HCacZ7zIg@wuerfel> References: <1412663852-32681-1-git-send-email-sonnyrao@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1412663852-32681-1-git-send-email-sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Sonny Rao , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lorenzo Pieralisi , pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, Marc Zyngier , Catalin Marinas , Daniel Lezcano , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Doug Anderson , galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Sudeep Holla , Olof Johansson , Nathan Lynch , Thomas Gleixner , Stephen Boyd List-Id: devicetree@vger.kernel.org On Monday 06 October 2014 23:37:32 Sonny Rao wrote: > > +#ifdef CONFIG_ARM > + /* > + * If we cannot rely on firmware initializing the CNTVOFF then > + * we should use the physical timers instead. > + */ > + if (of_property_read_bool(np, "arm,cntvoff-not-fw-configured")) > + arch_timer_use_virtual = false; > +#endif > + > Sorry for the nitpicking, but can this please use if (IS_ENABLED(CONFIG_ARM)) to avoid the ugly #ifdef? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html