Re: [PATCH v3 09/10] ARM: dts: introduce MPS2 AN385/AN386

Arnd Bergmann
2016-02-18T10:45:12Z

On Thursday 18 February 2016 10:11:37 Vladimir Murzin wrote:
>
> Right, I thought in a wrong way, in opposite it makes more sense now.
>
> .dtsi
>
> /* below the soc/ */
> smb {
> compatible = "simple-bus";
> #address-cells = <2>;
> #size-cells = <1>;
> ranges = <0 0 0x40200000 0x10000>,
> <1 0 0xa0000000 0x10000>;
> };

That looks good, yes.

Is 0x10000 the correct maximum addressable size of the external bus
in both cases?

Intuitively, I would guess that the 0xa0000000 range might
be much wider.

> .dts
>
> smb {
> ethernet@0,0 {
> compatible = "smsc,lan9220", "smsc,lan9115";
> reg = <0 0x0 0x10000>;
> interrupts = <13>;
> interrupt-parent = <&nvic>;
> smsc,irq-active-high;
> };
>
>
> and looking again at .dtsi it seems to me that fpgaio should be moved
> below the soc/ under separate bus interface which would hosts audio and
> spi too or I keep missing things around device-tree?
>

I don't see the audio and spi nodes, so I'm not sure where exactly
you would put them.

Ideally those things should be visible from a block diagram in the
datasheet.

Arnd