From: Krzysztof Kozlowski <krzk@kernel.org>
To: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Xiangxu Yin <xiangxu.yin@oss.qualcomm.com>,
Johan Hovold <johan+linaro@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Kathiravan Thirumoorthy
<kathiravan.thirumoorthy@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra
Date: Tue, 5 May 2026 15:29:07 +0200 [thread overview]
Message-ID: <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> (raw)
In-Reply-To: <95b567cc-b83c-4154-9520-e624555f1882@oss.qualcomm.com>
On 05/05/2026 15:27, Krishna Kurapati wrote:
>
>
> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote:
>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote:
>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote:
>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform.
>>>>
>>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>>> ---
>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>
>> ... and then I looked at the driver. So un-reviewed. Devices are clearly
>> compatible. If not, explain what is not compatible.
>>
> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK.
>
> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have
> GCC_USB3_PRIM_PHY_AUX_CLK.
>
> Hence, I didn't use a fallback compatible.
This still explains nothing. How different clock makes interface for SW
incompatible exactly?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-05 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 17:06 [PATCH v2 0/4] Add USB Phy driver and binding changes for Qualcomm Shikra SoC Krishna Kurapati
2026-05-04 17:06 ` [PATCH v2 1/4] dt-bindings: phy: qcom,qusb2: Document QUSB2 Phy for Shikra Krishna Kurapati
2026-05-05 10:48 ` Krzysztof Kozlowski
2026-05-04 17:06 ` [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support " Krishna Kurapati
2026-05-05 10:49 ` Krzysztof Kozlowski
2026-05-05 10:52 ` Krzysztof Kozlowski
2026-05-05 13:27 ` Krishna Kurapati
2026-05-05 13:29 ` Krzysztof Kozlowski [this message]
2026-05-05 13:57 ` Krishna Kurapati
2026-05-05 14:00 ` Krzysztof Kozlowski
2026-05-04 17:06 ` [PATCH v2 3/4] phy: qcom-qusb2: " Krishna Kurapati
2026-05-04 17:06 ` [PATCH v2 4/4] phy: qcom: qmp-usbc: Add qmp configuration " Krishna Kurapati
2026-05-04 19:28 ` Dmitry Baryshkov
2026-05-05 4:06 ` Krishna Kurapati
2026-05-05 10:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=johan+linaro@kernel.org \
--cc=kathiravan.thirumoorthy@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krishna.kurapati@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=xiangxu.yin@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox