From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC5618A6C2; Thu, 8 Aug 2024 10:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723112900; cv=none; b=Gcl2pi/FrlxcXmxJpDxUUc3en8wPfiZ32nPY6662XRZxBSFbv1QQ13PLgbKJarNqMuS6Gq7sjBA9pTwxb+0k4Bqdi4Cd+lBx2PVaR8S0MX593MDe5SeZ/RwCM1EFUwhyw7B/Qum+GgF6B6IPNraSB9jekUEW4zBVmT6PRJWsVDU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723112900; c=relaxed/simple; bh=intYcQDbZsn2duAHXMXmHdLSGdw1MRwxV58NXdIotYQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JffDRVJwZDpY6od+epbfGd5w/if0qViGI85wjhdztMPiDCSEO25yJApNeY7Fy/u8eg4A/0vtQWHPoG19tIiX+6PltA5JQo+uth1fDYuyYpT1OfVrV9NxKWlY8Medf6qwsDxF18bJdqncM+dRcob8FxBaPvwS7GPkGSzlvJY01ro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PjNgDEl4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PjNgDEl4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33E4BC32782; Thu, 8 Aug 2024 10:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723112899; bh=intYcQDbZsn2duAHXMXmHdLSGdw1MRwxV58NXdIotYQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PjNgDEl4VsgNp09L6gVKrUAccTmXQpKIs3m6TAgrqoQTxj+2iqlQdf6AuxfJsEiPC hPE5nkoHs8iOvRk02r+AAu91mz80+2arhy5ca76muzSwF6hs70XJcfuSLM56TgTTW+ kdKs8HsYfqNXdfq0EhAs2vGzYCMoWw5pO77FhWYiWc6Sx4z4OsoqYqWSpe7+SimLVZ lPKvNGdpX1sDzs6UOAjZdSzgu8UDl2fnBo6GrIdPDQH4PfgwYa8mR/Wk5AjbXrKp/n NM8iFftJrzM70Z1PaR1qf2qXgg5OpvTbeDkf9oCu7tOsiGZJVsSzLOVYPG6BMlbZHH pbhoObXLFrRMQ== Message-ID: <2975fb46-6145-4da3-8d8a-41f5d35db90c@kernel.org> Date: Thu, 8 Aug 2024 12:28:13 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] dt-bindings: ufs: Document Rockchip UFS host controller To: Shawn Lin , "Rob Herring (Arm)" Cc: linux-rockchip@lists.infradead.org, Liang Chen , Rob Herring , linux-kernel@vger.kernel.org, "Martin K . Petersen" , Conor Dooley , Bart Van Assche , Alim Akhtar , "James E . J . Bottomley" , YiFeng Zhao , Krzysztof Kozlowski , devicetree@vger.kernel.org, Manivannan Sadhasivam , Heiko Stuebner , Avri Altman , linux-scsi@vger.kernel.org References: <1723089163-28983-1-git-send-email-shawn.lin@rock-chips.com> <1723089163-28983-3-git-send-email-shawn.lin@rock-chips.com> <172309498853.3975217.8775988957925335272.robh@kernel.org> <659b9e09-b98d-48e0-ad0f-bfb2fe2148bc@rock-chips.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <659b9e09-b98d-48e0-ad0f-bfb2fe2148bc@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08/08/2024 08:10, Shawn Lin wrote: > Hi Rob > > 在 2024/8/8 13:29, Rob Herring (Arm) 写道: >> >> On Thu, 08 Aug 2024 11:52:42 +0800, Shawn Lin wrote: >>> Document Rockchip UFS host controller for RK3576 SoC. >>> >>> Signed-off-by: Shawn Lin >>> >>> --- >>> >>> Changes in v2: >>> - renmae file name >>> - fix all errors and pass the dt_binding_check: >>> make dt_binding_check DT_SCHEMA_FILES=rockchip,rk3576-ufs.yaml >>> >>> .../bindings/ufs/rockchip,rk3576-ufs.yaml | 96 ++++++++++++++++++++++ >>> 1 file changed, 96 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename >> $id: http://devicetree.org/schemas/ufs/rockchip,ufs.yaml >> file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.yaml > > This is already fixed by a resend v2 2/3 patch, a moment ago. Sorry for > that. If you change patches, it is not a resend. Send a proper new version with proper changelog. > >> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufs.example.dts:24:18: fatal error: dt-bindings/clock/rockchip,rk3576-cru.h: No such file or directory >> 24 | #include >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> compilation terminated. > > There are still pending patches from Rockchip in queue for review. This > patchset is based on them. I will wait for more comments and update them > after all under-review patches got merged. You need to document dependencies in changelog (---). Best regards, Krzysztof