From: Heiko Stuebner <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series
Date: Fri, 28 Jul 2017 11:25:36 +0200 [thread overview]
Message-ID: <2981514.6HN6ClsfAP@phil> (raw)
In-Reply-To: <1501049975-6185-1-git-send-email-mark.yao@rock-chips.com>
Hi Mark,
Am Mittwoch, 26. Juli 2017, 14:19:35 CEST schrieb Mark Yao:
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v5:
> - clean document commit title
> - move changes description out of docummit commit msg
>
> Changes in v2:
> - rename rk322x to rk3228
> - correct some vop registers define
>
> Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> index 9eb3f0a..5d835d9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,8 +8,12 @@ Required properties:
> - compatible: value should be one of the following
> "rockchip,rk3036-vop";
> "rockchip,rk3288-vop";
> + "rockchip,rk3368-vop";
> + "rockchip,rk3366-vop";
> "rockchip,rk3399-vop-big";
> "rockchip,rk3399-vop-lit";
> + "rockchip,rk3228-vop";
> + "rockchip,rk3328-vop";
what is your ordering scheme here?
As the number of rkXXXX socs will very likely increase in the future
ordering alphanumerical might make everything more manageable when
the list grows.
So maybe swap rk3368 and rk3366 and move rk3228+rk3328 to sorted
positions?
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-07-28 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 6:18 [PATCH v6 0/7] drm/rockchip: add all full framework vop support Mark Yao
2017-07-26 6:19 ` [PATCH v6 6/7] dt-bindings: display: rockchip: fill Documents for vop series Mark Yao
2017-07-28 9:25 ` Heiko Stuebner [this message]
2017-07-31 1:02 ` [PATCH v6 0/7] drm/rockchip: add all full framework vop support Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2981514.6HN6ClsfAP@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).