From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/4] soc: qcom: add an EBI2 device tree bindings Date: Mon, 08 Aug 2016 23:32:46 +0200 Message-ID: <2988918.zNxvaGl6en@wuerfel> References: <1470691445-27571-1-git-send-email-linus.walleij@linaro.org> <1470691445-27571-2-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1470691445-27571-2-git-send-email-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Linus Walleij , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andy Gross , David Brown , Stephen Boyd , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Andersson List-Id: devicetree@vger.kernel.org On Monday, August 8, 2016 11:24:02 PM CEST Linus Walleij wrote: > + > +Required subnode properties: > +- chipselect: where N is the chipselect configured in this node > +- address-cells: should be <1> > +- size-cells: should be <1> > +- ranges: bool should be present > I think this should use a proper ranges property that translates the address space of the external bus into the parent bus. Just use #address-cells=<2> and make the first cell the cs number, as the other similar drivers do, and get rid of the chipselect property. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html