* [PATCH] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED
@ 2023-05-14 19:58 André Apitzsch
2023-05-16 1:11 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: André Apitzsch @ 2023-05-14 19:58 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Stephan Gerhold,
André Apitzsch
l8910 uses OCP8110 flash LED driver. Add it to the device tree.
Tested-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: André Apitzsch <git@apitzsch.eu>
---
.../boot/dts/qcom/msm8916-longcheer-l8910.dts | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
index b79e80913af9..81cebac117f1 100644
--- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
+++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
@@ -20,6 +20,21 @@ chosen {
stdout-path = "serial0";
};
+ flash-led-controller {
+ compatible = "ocs,ocp8110";
+ enable-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>;
+ flash-gpios = <&msmgpio 119 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&camera_front_flash_default>;
+
+ flash_led: led {
+ function = LED_FUNCTION_FLASH;
+ color = <LED_COLOR_ID_WHITE>;
+ flash-max-timeout-us = <250000>;
+ };
+ };
+
gpio-keys {
compatible = "gpio-keys";
@@ -246,6 +261,14 @@ button_backlight_default: button-backlight-default-state {
bias-disable;
};
+ camera_front_flash_default: camera-front-flash-default-state {
+ pins = "gpio49", "gpio119";
+ function = "gpio";
+
+ drive-strength = <2>;
+ bias-disable;
+ };
+
gpio_keys_default: gpio-keys-default-state {
pins = "gpio107";
function = "gpio";
---
base-commit: 533c54547153d46c0bf99ac0e396bed71f760c03
change-id: 20230514-x5_front_flash-c189e22b32fd
Best regards,
--
André Apitzsch <git@apitzsch.eu>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED
2023-05-14 19:58 [PATCH] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED André Apitzsch
@ 2023-05-16 1:11 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-05-16 1:11 UTC (permalink / raw)
To: André Apitzsch, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Stephan Gerhold
On 14.05.2023 21:58, André Apitzsch wrote:
> l8910 uses OCP8110 flash LED driver. Add it to the device tree.
>
> Tested-by: Stephan Gerhold <stephan@gerhold.net>
> Signed-off-by: André Apitzsch <git@apitzsch.eu>
> ---
> .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> index b79e80913af9..81cebac117f1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> @@ -20,6 +20,21 @@ chosen {
> stdout-path = "serial0";
> };
>
> + flash-led-controller {
> + compatible = "ocs,ocp8110";
> + enable-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>;
> + flash-gpios = <&msmgpio 119 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&camera_front_flash_default>;
property-n
property-names
please!
> +
> + flash_led: led {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + flash-max-timeout-us = <250000>;
> + };
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
>
> @@ -246,6 +261,14 @@ button_backlight_default: button-backlight-default-state {
> bias-disable;
> };
>
> + camera_front_flash_default: camera-front-flash-default-state {
> + pins = "gpio49", "gpio119";
> + function = "gpio";
> +
Unnecessary newline
LGTM otherwise!
Konrad
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> gpio_keys_default: gpio-keys-default-state {
> pins = "gpio107";
> function = "gpio";
>
> ---
> base-commit: 533c54547153d46c0bf99ac0e396bed71f760c03
> change-id: 20230514-x5_front_flash-c189e22b32fd
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-16 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-14 19:58 [PATCH] arm64: dts: qcom: msm8916-longcheer-l8910: Add front flash LED André Apitzsch
2023-05-16 1:11 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).