Re: [PATCH v4 1/2] ARM: keystone: pm: switch to use generic pm domains

Grygorii Strashko
2014-11-25T13:30:20Z

On 11/25/2014 02:09 PM, Arnd Bergmann wrote:
> On Tuesday 25 November 2014 13:08:57 Grygorii Strashko wrote:
>> On 11/25/2014 12:33 PM, Arnd Bergmann wrote:
>>> On Monday 24 November 2014 22:44:06 Mike Turquette wrote:
>>>> Quoting Arnd Bergmann (2014-11-24 02:50:28)
>>>>>
>>>
>>> I'm not sure I even understand what you intended the example to look
>>> like, it does't parse
>>>
>>> My point above was completely different, the suggestion I made was
>>> to not classify the clocks in DT at all, but to leave it all in
>>> the client driver.
>>
>> I slept with this idea From one side it sounds good. Pls, Correct me if I'm wrong:
>> - there still will be "simple-pmdomain" and all devices will be attached to it by
>> default (or as specified in DT power-domains = <&simple_pmdomain>;);
>
> I would assume only devices that set "power-domains = <&simple_pmdomain>"
>
>> - drivers will use smth. like pm_clk_remove() to remove optional clocks from pm_clk;
>
> Right. Regarding the naming of the function, I would pick something other
> than remove, since the main purpose is not to have that clock abandoned
> by the pm-domain code (this is still a side-effect), but to have the
> clock put under control of the driver itself.

pm_clk_remove() is implemented already.

>
> It might be possible to do this implicitly if the driver calls clk_get(),
> basically doing clk_get() (or another call if necessary) would prevent the
> simple pmdomain from turning it off during suspend.

Unfortunately, clk_get() will not work, because drivers still need to use it
to get functional clocks even if they are not going to control them explicitly.
For example, if it need to know clock's rate.

>
>> From another side:
>> - drivers will get dependency from pm_clk;
>
> There are three cases here:
>
> - A device that is always used with a pm-domain, the driver doesn't
> have to worry about it but do need the dependency on having the
> simple-pmdomain code enabled.
>
> - A device that may or may not have clocks, but if it has them, they
> are managed through a pm-domain. In this case, it's platform dependent
> whether we have the dependency. We may want to prevent the device from
> being probed if a power-domain property is present but no driver
> for the domain.

Seems, solved by PM core - .probe() will be deferred forever if pm-domain is
not ready.

>
> - A device that uses the pm-domain on some machines but not on others:
> this is a bit tricky, because the driver will still have to know
> about all the clocks, although we could choose not to turn off the
> clocks during suspend if the power-domain is not set.
>
>> - HW limitations can't be taken into account - it's possible that some clocks should
>> not be enabled until it's allowed. And only driver know when it's allowed.
>> Otherwise, HW state may become unspecified or wrong output can be generated.
>
> Correct: if you have a device that you don't want to be handled by a simple
> pm-domain, then you have to connect it to a different pm-domain, e.g. one that
> manages a fixed set of clocks itself.

regards,
-grygorii